Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-combobox): Clearable Dropdowns and Comboboxes do not show clear button if they are disabled #33251

Conversation

khmakoto
Copy link
Member

Previous Behavior

When the Dropdown and Combobox components were clearable and disabled, the clear button was still visible and interactive even though the components themselves were disabled.

New Behavior

When the Dropdown and Combobox components are clearable, if they are disabled, then the clear button is not visible anymore.

Related Issue(s)

…hey are disabled.
@khmakoto khmakoto requested review from a team as code owners November 11, 2024 22:34

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-combobox
Combobox (including child components)
104.383 kB
34.197 kB
104.387 kB
34.201 kB
4 B
4 B
react-combobox
Dropdown (including child components)
104.996 kB
34.122 kB
105.011 kB
34.126 kB
15 B
4 B
react-components
react-components: entire library
1.162 MB
291.009 kB
1.162 MB
290.986 kB
19 B
-23 B
react-timepicker-compat
TimePicker
107.372 kB
35.755 kB
107.376 kB
35.759 kB
4 B
4 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
69.21 kB
20.174 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
220.616 kB
63.902 kB
react-components
react-components: FluentProvider & webLightTheme
44.447 kB
14.59 kB
react-portal-compat
PortalCompatProvider
8.39 kB
2.64 kB
react-tag-picker
@fluentui/react-tag-picker - package
184.091 kB
55.425 kB
🤖 This report was generated against 2878503f1381bfa2aaf6900fba4170d9db1b74a6

Copy link

Pull request demo site: URL

@khmakoto khmakoto merged commit c70e793 into microsoft:master Nov 12, 2024
16 checks passed
@khmakoto khmakoto deleted the fix/react-combobox/clearableNotVisibleWhenDisabled branch January 7, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Dropdown is still clearable when disabled
4 participants