-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(v8 DatePicker): Add aria-required
to required DatePickers
#33239
Merged
emmayjiang
merged 4 commits into
microsoft:master
from
emmayjiang:v8-datepicker-required-fix
Nov 11, 2024
Merged
fix(v8 DatePicker): Add aria-required
to required DatePickers
#33239
emmayjiang
merged 4 commits into
microsoft:master
from
emmayjiang:v8-datepicker-required-fix
Nov 11, 2024
+11
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size reportUnchanged fixtures
|
fabricteam
reviewed
Nov 9, 2024
Pull request demo site: URL |
smhigley
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Screenreaders did not announce when a DatePicker was required because of the lack of
aria-required
attriute.New Behavior
Screenreaders will now announce when a DatePicker is required.
Related Issue(s)