Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v8 DatePicker): Add aria-required to required DatePickers #33239

Merged
merged 4 commits into from
Nov 11, 2024

Conversation

emmayjiang
Copy link
Contributor

Previous Behavior

Screenreaders did not announce when a DatePicker was required because of the lack of aria-required attriute.

New Behavior

Screenreaders will now announce when a DatePicker is required.

Related Issue(s)

Copy link

github-actions bot commented Nov 8, 2024

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react
DatePicker
184.284 kB
56.154 kB
184.302 kB
56.159 kB
18 B
5 B
react
ExtendedPicker
96.873 kB
27.893 kB
96.873 kB
27.892 kB

-1 B
react
FloatingPicker
242.356 kB
69.005 kB
242.356 kB
69.006 kB

1 B
react
Pickers
294.328 kB
82.365 kB
294.328 kB
82.366 kB

1 B
react
Fluent UI React (entire library)
1.014 MB
281.695 kB
1.014 MB
281.705 kB
18 B
10 B
react
SelectedItemsList
232.868 kB
67.895 kB
232.868 kB
67.897 kB

2 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react
ActivityItem
71.236 kB
23.357 kB
react
Announced
38.489 kB
13.296 kB
react
Autofill
15.42 kB
4.766 kB
react
Breadcrumb
202.308 kB
60.391 kB
react
Button
195.781 kB
56.634 kB
react
ButtonGrid
180.729 kB
54.641 kB
react
Calendar
121.882 kB
37.032 kB
react
Callout
84.33 kB
27.648 kB
react
Check
53.204 kB
17.848 kB
react
Checkbox
59.985 kB
19.903 kB
react
ChoiceGroup
65.494 kB
21.489 kB
react
ChoiceGroupOption
58.767 kB
19.362 kB
react
Coachmark
93.151 kB
29.428 kB
react
Color
7.789 kB
3.127 kB
react
ColorPicker
135.292 kB
42.21 kB
react
ComboBox
252.193 kB
72.294 kB
react
CommandBar
203.349 kB
60.142 kB
react
ContextualMenu
155.25 kB
48.215 kB
react
DateTimeUtilities
5.244 kB
1.849 kB
react
DetailsList
229.913 kB
65.787 kB
react
Dialog
211.707 kB
63.166 kB
react
Divider
19.603 kB
6.845 kB
react
DocumentCard
217.326 kB
64.436 kB
react
DragDrop
8.343 kB
2.724 kB
react
DraggableZone
34.303 kB
11.511 kB
react
Dropdown
234.241 kB
68.617 kB
react
Fabric
41.745 kB
14.366 kB
react
Facepile
210.9 kB
63.183 kB
react
FocusTrapZone
17.03 kB
5.924 kB
react
FocusZone
55.159 kB
17.492 kB
react
Grid
180.729 kB
54.641 kB
react
GroupedList
135.074 kB
40.705 kB
react
GroupedListV2
122.691 kB
37.794 kB
react
HoverCard
97.167 kB
30.794 kB
react
Icon
51.885 kB
17.272 kB
react
Icons
66.361 kB
24.397 kB
react
Image
46.904 kB
15.707 kB
react
Keytip
81.693 kB
26.766 kB
react
KeytipData
14.039 kB
4.588 kB
react
KeytipLayer
103.474 kB
32.015 kB
react
Keytips
106.246 kB
33.023 kB
react
Label
38.347 kB
13.257 kB
react
Layer
48.099 kB
16.367 kB
react
Link
39.682 kB
13.67 kB
react
List
39.371 kB
12.463 kB
react
MarqueeSelection
74.517 kB
22.433 kB
react
MessageBar
190.859 kB
57.107 kB
react
Modal
93.745 kB
30.279 kB
react
Nav
188.313 kB
56.502 kB
react
OverflowSet
33.393 kB
11.329 kB
react
Overlay
40.902 kB
14.095 kB
react
Panel
201.354 kB
59.981 kB
react
Persona
114.948 kB
36.532 kB
react
PersonaCoin
114.948 kB
36.532 kB
react
PersonaPresence
58.074 kB
19.384 kB
react
Pivot
189.227 kB
57.281 kB
react
Popup
12.294 kB
4.195 kB
react
Positioning
22.807 kB
7.701 kB
react
PositioningContainer
73.85 kB
23.765 kB
react
ProgressIndicator
39.494 kB
13.55 kB
react
Rating
82.12 kB
26.127 kB
react
ResizeGroup
13.338 kB
4.377 kB
react
ResponsiveMode
8.13 kB
2.966 kB
react
ScrollablePane
55.557 kB
17.728 kB
react
SearchBox
189.108 kB
56.682 kB
react
SelectableOption
724 B
413 B
react
Selection
42.444 kB
12.278 kB
react
Separator
35.384 kB
12.146 kB
react
Shimmer
49.259 kB
16.268 kB
react
ShimmeredDetailsList
240.695 kB
68.536 kB
react
Slider
57.651 kB
19.217 kB
react
SpinButton
192.811 kB
57.779 kB
react
Spinner
41.775 kB
14.48 kB
react
Stack
41.734 kB
14.268 kB
react
Sticky
32.599 kB
10.504 kB
react
Styling
46.033 kB
15.135 kB
react
SwatchColorPicker
191.114 kB
58.149 kB
react
TeachingBubble
206.106 kB
61.06 kB
react
Text
36.908 kB
12.822 kB
react
TextField
80.79 kB
25.315 kB
react
Theme
43.501 kB
14.183 kB
react
ThemeGenerator
12.392 kB
4.126 kB
react
TimePicker
242.004 kB
70.053 kB
react
Toggle
46.225 kB
15.986 kB
react
Tooltip
87.437 kB
28.26 kB
react
Utilities
82.931 kB
25.148 kB
react
Viewport
23.888 kB
7.656 kB
react
WeeklyDayPicker
102.025 kB
31.846 kB
react
WindowProvider
1.059 kB
541 B
🤖 This report was generated against 027ab04e8d35e90f7d3cecf78c12d86b600e9716

Copy link

github-actions bot commented Nov 9, 2024

Pull request demo site: URL

@emmayjiang emmayjiang marked this pull request as ready for review November 9, 2024 00:44
@emmayjiang emmayjiang requested a review from a team as a code owner November 9, 2024 00:44
@emmayjiang emmayjiang enabled auto-merge (squash) November 11, 2024 18:40
@emmayjiang emmayjiang disabled auto-merge November 11, 2024 18:41
@emmayjiang emmayjiang merged commit 2878503 into microsoft:master Nov 11, 2024
16 checks passed
@emmayjiang emmayjiang deleted the v8-datepicker-required-fix branch November 11, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants