Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(react-combobox): rollback export of internal hooks #30648

Conversation

bsunderhus
Copy link
Contributor

@bsunderhus bsunderhus commented Feb 28, 2024

Previous Behavior

New Behavior

  1. Rollback from feature(react-combobox): export internal hooks and types #30646 as those hooks are unstable and cannot be exported
  2. copy hooks from react-combobox to react-tag-picker-preview package manually

Related Issue(s)

  • Fixes #

@bsunderhus bsunderhus self-assigned this Feb 28, 2024
@bsunderhus bsunderhus marked this pull request as ready for review February 28, 2024 13:06
@bsunderhus bsunderhus requested review from a team and smhigley as code owners February 28, 2024 13:06
@bsunderhus bsunderhus force-pushed the react-combobox/chore--rollback-export-of-internal-hooks branch from 3bcd7da to 4a3035e Compare February 28, 2024 13:08
@fabricteam
Copy link
Collaborator

fabricteam commented Feb 28, 2024

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-combobox
Combobox (including child components)
102.463 kB
33.101 kB
react-combobox
Dropdown (including child components)
103.837 kB
33.038 kB
react-components
react-components: Button, FluentProvider & webLightTheme
70.732 kB
20.465 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
217.207 kB
61.943 kB
react-components
react-components: FluentProvider & webLightTheme
43.219 kB
14.299 kB
react-portal-compat
PortalCompatProvider
7.944 kB
2.588 kB
react-timepicker-compat
TimePicker
104.484 kB
34.49 kB
🤖 This report was generated against a64d8f6f2cabdc7a2d4b2badbddad04cbe68f1e1

@bsunderhus bsunderhus force-pushed the react-combobox/chore--rollback-export-of-internal-hooks branch from 4a3035e to 926913d Compare February 28, 2024 13:09
@bsunderhus bsunderhus enabled auto-merge (squash) February 28, 2024 13:13
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@bsunderhus
Copy link
Contributor Author

/azp-run

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
FluentProviderWithTheme virtual-rerender 65 61 10 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 660 644 5000
Button mount 321 301 5000
Field mount 1116 1146 5000
FluentProvider mount 692 732 5000
FluentProviderWithTheme mount 79 81 10
FluentProviderWithTheme virtual-rerender 65 61 10 Possible regression
FluentProviderWithTheme virtual-rerender-with-unmount 80 70 10
MakeStyles mount 847 849 50000
Persona mount 1724 1720 5000
SpinButton mount 1372 1375 5000

@bsunderhus bsunderhus merged commit c7342e3 into microsoft:master Feb 29, 2024
17 of 19 checks passed
@bsunderhus bsunderhus deleted the react-combobox/chore--rollback-export-of-internal-hooks branch February 29, 2024 09:53
@fabricteam
Copy link
Collaborator

🕵 fluentuiv9 No visual regressions between this PR and main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants