Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react-tags): export TagGroupContextValues type #30645

Conversation

bsunderhus
Copy link
Contributor

@bsunderhus bsunderhus commented Feb 28, 2024

Previous Behavior

New Behavior

  1. Exports TagGroupContextValues

Related Issue(s)

  • Fixes #

@bsunderhus bsunderhus self-assigned this Feb 28, 2024
@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 607 627 5000
Button mount 284 302 5000
Field mount 1118 1150 5000
FluentProvider mount 694 704 5000
FluentProviderWithTheme mount 85 90 10
FluentProviderWithTheme virtual-rerender 55 53 10
FluentProviderWithTheme virtual-rerender-with-unmount 80 74 10
MakeStyles mount 848 838 50000
Persona mount 1774 1703 5000
SpinButton mount 1390 1303 5000

@bsunderhus bsunderhus marked this pull request as ready for review February 28, 2024 10:51
@bsunderhus bsunderhus requested review from a team as code owners February 28, 2024 10:51
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
70.732 kB
20.465 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
217.207 kB
61.943 kB
react-components
react-components: FluentProvider & webLightTheme
43.219 kB
14.299 kB
react-portal-compat
PortalCompatProvider
7.944 kB
2.588 kB
react-tags
InteractionTag
15.259 kB
6.058 kB
react-tags
Tag
29.982 kB
9.439 kB
react-tags
TagGroup
80.556 kB
24.027 kB
🤖 This report was generated against d27ded5aae466199135de53d143cc9d88659770d

@fabricteam
Copy link
Collaborator

🕵 fluentuiv9 No visual regressions between this PR and main

@bsunderhus bsunderhus merged commit ace98f7 into microsoft:master Feb 28, 2024
19 checks passed
@bsunderhus bsunderhus deleted the react-tags/feat--export-TagGroupContextValues-type branch February 28, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants