New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: switch to Stackblitz export #30613
docs: switch to Stackblitz export #30613
Conversation
2a69b8b
to
7fd2313
Compare
馃搳 Bundle size reportUnchanged fixtures
|
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 629 | 656 | 5000 | |
Button | mount | 306 | 302 | 5000 | |
Field | mount | 1130 | 1123 | 5000 | |
FluentProvider | mount | 695 | 685 | 5000 | |
FluentProviderWithTheme | mount | 79 | 80 | 10 | |
FluentProviderWithTheme | virtual-rerender | 60 | 63 | 10 | |
FluentProviderWithTheme | virtual-rerender-with-unmount | 72 | 79 | 10 | |
MakeStyles | mount | 841 | 852 | 50000 | |
Persona | mount | 1717 | 1704 | 5000 | |
SpinButton | mount | 1389 | 1365 | 5000 |
Perf Analysis (
|
Scenario | Current PR Ticks | Baseline Ticks | Ratio |
---|---|---|---|
ListCommonPerf.default | 418 | 367 | 1.14:1 |
ProviderMinimalPerf.default | 210 | 191 | 1.1:1 |
ReactionMinimalPerf.default | 225 | 207 | 1.09:1 |
AnimationMinimalPerf.default | 309 | 286 | 1.08:1 |
RefMinimalPerf.default | 116 | 107 | 1.08:1 |
PortalMinimalPerf.default | 90 | 84 | 1.07:1 |
TextAreaMinimalPerf.default | 289 | 270 | 1.07:1 |
FormMinimalPerf.default | 227 | 215 | 1.06:1 |
AttachmentMinimalPerf.default | 85 | 81 | 1.05:1 |
AvatarMinimalPerf.default | 113 | 108 | 1.05:1 |
HeaderSlotsPerf.default | 471 | 450 | 1.05:1 |
HeaderMinimalPerf.default | 213 | 204 | 1.04:1 |
LoaderMinimalPerf.default | 199 | 192 | 1.04:1 |
SplitButtonMinimalPerf.default | 2299 | 2212 | 1.04:1 |
AttachmentSlotsPerf.default | 637 | 619 | 1.03:1 |
ButtonMinimalPerf.default | 90 | 87 | 1.03:1 |
ButtonSlotsPerf.default | 325 | 315 | 1.03:1 |
CardMinimalPerf.default | 308 | 300 | 1.03:1 |
ChatMinimalPerf.default | 456 | 444 | 1.03:1 |
CheckboxMinimalPerf.default | 1133 | 1096 | 1.03:1 |
GridMinimalPerf.default | 188 | 182 | 1.03:1 |
ListNestedPerf.default | 335 | 326 | 1.03:1 |
SliderMinimalPerf.default | 750 | 730 | 1.03:1 |
DividerMinimalPerf.default | 202 | 198 | 1.02:1 |
DropdownManyItemsPerf.default | 399 | 390 | 1.02:1 |
DropdownMinimalPerf.default | 1419 | 1393 | 1.02:1 |
ListWith60ListItems.default | 359 | 353 | 1.02:1 |
PopupMinimalPerf.default | 352 | 346 | 1.02:1 |
TableMinimalPerf.default | 243 | 239 | 1.02:1 |
TreeMinimalPerf.default | 491 | 480 | 1.02:1 |
BoxMinimalPerf.default | 194 | 193 | 1.01:1 |
InputMinimalPerf.default | 531 | 526 | 1.01:1 |
ProviderMergeThemesPerf.default | 660 | 651 | 1.01:1 |
RadioGroupMinimalPerf.default | 259 | 256 | 1.01:1 |
SegmentMinimalPerf.default | 193 | 192 | 1.01:1 |
SkeletonMinimalPerf.default | 202 | 200 | 1.01:1 |
TextMinimalPerf.default | 196 | 194 | 1.01:1 |
ToolbarMinimalPerf.default | 549 | 541 | 1.01:1 |
ChatDuplicateMessagesPerf.default | 148 | 148 | 1:1 |
DatepickerMinimalPerf.default | 3526 | 3514 | 1:1 |
DialogMinimalPerf.default | 441 | 443 | 1:1 |
EmbedMinimalPerf.default | 1843 | 1840 | 1:1 |
LabelMinimalPerf.default | 210 | 211 | 1:1 |
MenuMinimalPerf.default | 498 | 499 | 1:1 |
IconMinimalPerf.default | 386 | 385 | 1:1 |
CustomToolbarPrototype.default | 1451 | 1450 | 1:1 |
AlertMinimalPerf.default | 158 | 159 | 0.99:1 |
ItemLayoutMinimalPerf.default | 689 | 699 | 0.99:1 |
MenuButtonMinimalPerf.default | 943 | 951 | 0.99:1 |
StatusMinimalPerf.default | 391 | 395 | 0.99:1 |
TableManyItemsPerf.default | 1069 | 1081 | 0.99:1 |
AccordionMinimalPerf.default | 83 | 85 | 0.98:1 |
CarouselMinimalPerf.default | 256 | 262 | 0.98:1 |
ImageMinimalPerf.default | 224 | 229 | 0.98:1 |
ListMinimalPerf.default | 305 | 311 | 0.98:1 |
FlexMinimalPerf.default | 153 | 158 | 0.97:1 |
RosterPerf.default | 1541 | 1581 | 0.97:1 |
VideoMinimalPerf.default | 419 | 432 | 0.97:1 |
ButtonOverridesMissPerf.default | 637 | 666 | 0.96:1 |
ChatWithPopoverPerf.default | 187 | 194 | 0.96:1 |
TooltipMinimalPerf.default | 1226 | 1278 | 0.96:1 |
LayoutMinimalPerf.default | 187 | 197 | 0.95:1 |
TreeWith60ListItems.default | 86 | 91 | 0.95:1 |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
馃暤 fluentuiv8 No visual regressions between this PR and main |
馃暤 FluentUIV0 No visual regressions between this PR and main |
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
BaseButton | mount | 644 | 624 | 5000 | |
Breadcrumb | mount | 1718 | 1698 | 1000 | |
Checkbox | mount | 1710 | 1681 | 5000 | |
CheckboxBase | mount | 1469 | 1507 | 5000 | |
ChoiceGroup | mount | 2944 | 2915 | 5000 | |
ComboBox | mount | 664 | 665 | 1000 | |
CommandBar | mount | 6210 | 6257 | 1000 | |
ContextualMenu | mount | 12593 | 12610 | 1000 | |
DefaultButton | mount | 764 | 749 | 5000 | |
DetailsRow | mount | 2160 | 2164 | 5000 | |
DetailsRowFast | mount | 2176 | 2215 | 5000 | |
DetailsRowNoStyles | mount | 2039 | 2025 | 5000 | |
Dialog | mount | 2681 | 2670 | 1000 | |
DocumentCardTitle | mount | 230 | 218 | 1000 | |
Dropdown | mount | 1948 | 1975 | 5000 | |
FocusTrapZone | mount | 1156 | 1161 | 5000 | |
FocusZone | mount | 1099 | 1083 | 5000 | |
GroupedList | mount | 41917 | 42164 | 2 | |
GroupedList | virtual-rerender | 20183 | 20225 | 2 | |
GroupedList | virtual-rerender-with-unmount | 50708 | 50637 | 2 | |
GroupedListV2 | mount | 225 | 226 | 2 | |
GroupedListV2 | virtual-rerender | 204 | 211 | 2 | |
GroupedListV2 | virtual-rerender-with-unmount | 218 | 223 | 2 | |
IconButton | mount | 1058 | 1097 | 5000 | |
Label | mount | 337 | 342 | 5000 | |
Layer | mount | 2742 | 2762 | 5000 | |
Link | mount | 391 | 385 | 5000 | |
MenuButton | mount | 922 | 952 | 5000 | |
MessageBar | mount | 21193 | 21189 | 5000 | |
Nav | mount | 1940 | 1915 | 1000 | |
OverflowSet | mount | 782 | 769 | 5000 | |
Panel | mount | 2073 | 1738 | 1000 | |
Persona | mount | 745 | 738 | 1000 | |
Pivot | mount | 890 | 842 | 1000 | |
PrimaryButton | mount | 835 | 839 | 5000 | |
Rating | mount | 4613 | 4686 | 5000 | |
SearchBox | mount | 902 | 915 | 5000 | |
Shimmer | mount | 1871 | 1848 | 5000 | |
Slider | mount | 1301 | 1307 | 5000 | |
SpinButton | mount | 2898 | 2845 | 5000 | |
Spinner | mount | 382 | 383 | 5000 | |
SplitButton | mount | 1844 | 1820 | 5000 | |
Stack | mount | 409 | 395 | 5000 | |
StackWithIntrinsicChildren | mount | 856 | 854 | 5000 | |
StackWithTextChildren | mount | 2628 | 2588 | 5000 | |
SwatchColorPicker | mount | 6227 | 6148 | 5000 | |
TagPicker | mount | 1479 | 1443 | 5000 | |
Text | mount | 373 | 368 | 5000 | |
TextField | mount | 925 | 908 | 5000 | |
ThemeProvider | mount | 837 | 831 | 5000 | |
ThemeProvider | virtual-rerender | 585 | 590 | 5000 | |
ThemeProvider | virtual-rerender-with-unmount | 1272 | 1258 | 5000 | |
Toggle | mount | 628 | 602 | 5000 | |
buttonNative | mount | 186 | 186 | 5000 |
馃暤 fluentuiv9 No visual regressions between this PR and main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this change!
packages/react-components/react-storybook-addon-export-to-sandbox/src/sandbox-scaffold.ts
Show resolved
Hide resolved
yeah I noticed this as well, wondering if we should remove codesanbox API completely from our SB plugin implementation because of that , especially when we plan to make it public. WDYT ? |
No strong opinions about this. I don't think that CSB is usable in current reality with these restrictions. |
Previous Behavior
We used Codesandbox for export.
New Behavior
We use Stackblitz for export.
Also bumped exports to use Vite 5 & React 18.
Motivation
CodeSandbox recently changes their policies and now you have only 10 (private by default) sandboxes, so folks in the crew have this problem:
And to avoid it, we have to manually port code to Stackblitz 馃憥 That's a huge PITA in our workflow.