Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixing Rating focus border styling #30581

Merged
merged 3 commits into from
Feb 21, 2024

Conversation

tomi-msft
Copy link
Contributor

This PR is to add focus border styling to Rating.

@tomi-msft tomi-msft requested a review from a team as a code owner February 20, 2024 23:04
@fabricteam
Copy link
Collaborator

fabricteam commented Feb 20, 2024

📊 Bundle size report

🤖 This report was generated against a0bb58f2ac1d9f50bce33b7a9c4fb6b09922a956

Copy link

codesandbox-ci bot commented Feb 20, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@fabricteam
Copy link
Collaborator

fabricteam commented Feb 20, 2024

🕵 fluentuiv9 No visual regressions between this PR and main

Copy link
Contributor

@sopranopillow sopranopillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding some screenshots of before and after? :)

@behowell
Copy link
Contributor

Would you mind adding some screenshots of before and after? :)

@sopranopillow Not exactly what you asked for, but in case you didn't know, you can see the docsite with changes in this PR if you click Details next to Pull request demo site in the list of checks.

@khmakoto khmakoto changed the title Fix Rating focus border styling fix: Fixing Rating focus border styling Feb 21, 2024
@tomi-msft tomi-msft merged commit 04dcf21 into microsoft:master Feb 21, 2024
18 checks passed
@tomi-msft tomi-msft deleted the react-rating-focus-border-fix branch February 22, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants