feat(swatch-picker): Added ColorSwatch sub component and selection logic #30544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ValentinaKozlova
commented
Feb 13, 2024
•
ValentinaKozlova
commented
- Added ColorSwatch sub component
- Added selection logic
📊 Bundle size report🤖 This report was generated against be0c9ec2df6d510aa713584f65a43b88f4169fef |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 635 | 659 | 5000 | |
| Button | mount | 287 | 303 | 5000 | |
| Field | mount | 1143 | 1111 | 5000 | |
| FluentProvider | mount | 691 | 699 | 5000 | |
| FluentProviderWithTheme | mount | 74 | 79 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 68 | 66 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 74 | 78 | 10 | |
| MakeStyles | mount | 863 | 841 | 50000 | |
| Persona | mount | 1747 | 1714 | 5000 | |
| SpinButton | mount | 1412 | 1396 | 5000 |
🕵 fluentuiv9 No visual regressions between this PR and main |
...act-components/react-swatch-picker-preview/src/components/SwatchPicker/SwatchPicker.types.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-swatch-picker-preview/src/contexts/swatchPicker.ts
Outdated
Show resolved
Hide resolved
...eact-components/react-shared-contexts/src/CustomStyleHooksContext/CustomStyleHooksContext.ts
Outdated
Show resolved
Hide resolved
packages/react-components/react-swatch-picker-preview/src/contexts/swatch.ts
Outdated
Show resolved
Hide resolved
...-components/react-swatch-picker-preview/stories/SwatchPicker/SwatchPickerDefault.stories.tsx
Outdated
Show resolved
Hide resolved
...-components/react-swatch-picker-preview/stories/SwatchPicker/SwatchPickerDefault.stories.tsx
Outdated
Show resolved
Hide resolved
...-components/react-swatch-picker-preview/stories/SwatchPicker/SwatchPickerDefault.stories.tsx
Outdated
Show resolved
Hide resolved
...ct-components/react-swatch-picker-preview/src/components/ColorSwatch/useColorSwatchState.tsx
Outdated
Show resolved
Hide resolved
...es/react-components/react-swatch-picker-preview/src/components/ColorSwatch/useColorSwatch.ts
Outdated
Show resolved
Hide resolved
...es/react-components/react-swatch-picker-preview/src/components/ColorSwatch/useColorSwatch.ts
Outdated
Show resolved
Hide resolved
...es/react-components/react-swatch-picker-preview/src/components/ColorSwatch/useColorSwatch.ts
Outdated
Show resolved
Hide resolved
...es/react-components/react-swatch-picker-preview/src/components/ColorSwatch/useColorSwatch.ts
Outdated
Show resolved
Hide resolved
Hotell
reviewed
Feb 14, 2024
...react-components/react-swatch-picker-preview/src/components/ColorSwatch/ColorSwatch.test.tsx
Outdated
Show resolved
Hide resolved
…onents/ColorSwatch/useColorSwatch.ts Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
…SwatchPicker/SwatchPickerDefault.stories.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Hotell
reviewed
Feb 19, 2024
...es/react-components/react-swatch-picker-preview/src/components/SwatchPicker/SwatchPicker.tsx
Outdated
Show resolved
Hide resolved
…onents/ColorSwatch/useColorSwatchStyles.styles.ts Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
…onents/ColorSwatch/useColorSwatchStyles.styles.ts Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
…onents/ColorSwatch/useColorSwatchStyles.styles.ts Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
…onents/ColorSwatch/useColorSwatchStyles.styles.ts Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
…onents/ColorSwatch/useColorSwatchStyles.styles.ts Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
…onents/SwatchPicker/useSwatchPickerState.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
layershifter
approved these changes
Feb 21, 2024
Hotell
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.