Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump jest-axe from 6.0.1 to 8.0.0 #30309

Merged
merged 5 commits into from Feb 29, 2024

Conversation

Shubhabrata08
Copy link
Contributor

@Shubhabrata08 Shubhabrata08 commented Jan 13, 2024

Previous Behavior

jest-axe for FluentUI was at v6.0.1

New Behavior

jest-axe for FluentUI bumped up to 8.0.0
This ensures all further developments in FluentUI that use jest-axe for accessibility testing are in compliance with the latest axe-core rules supported by jest-axe.
Here's a demo test:
image

image

The test fails in jest-axe 6.0.1

image
The test passes in jest-axe 8.0.0 as an exception for 20+ hour time values was added for meta refresh tags and a no-exception optional rule was added to axe-core.

Related Issue(s)

  • Fixes #

Copy link

codesandbox-ci bot commented Jan 13, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@Shubhabrata08
Copy link
Contributor Author

Shubhabrata08 commented Jan 14, 2024

Here is the list of changes to axe-core from v4.4.1 to v4.7.2

Deprecate not-html-matches, use :

1.not(html) instead

area-alt:

  1. Remove the wcag111 tag

aria-allowed-role:

  1. allow combobox on button, checkbox and combobox on input[type=button]

aria-hidden-focus:

  1. Remove the wcag131 tag
  2. Do not fail for focus trap bumper elements
  3. Update rule help & description

aria-hidden-focusable:

  1. report incomplete with onfocus

aria-input-field-name:

  1. skip combobox popups

aria-required-attr:

  1. require aria-controls on combobox and aria-valuenow on focusable separator
  2. aria-valuenow is no longer required for spinbutton

aria-required-children:

  1. set related nodes for invalid children
  2. trigger reviewEmpty with hidden children
  3. allow separator in menu(bar)
  4. do not fail for children with aria-hidden
  5. list elements that are not allowed
  6. allow separator in menu(bar)
  7. allow menu as child of menu
  8. allow menu and menubar to be empty
  9. Allow aria-busy on children
  10. Fail for children which are not listed as required

aria-required-parent:

  1. Allow nested group and presentational roles

aria-roledescription:

  1. deprecate rule

aria-roles:

  1. deprecate the ARIA directory role
  2. Permit fallback roles

aria-valid-attr-value:

  1. Report empty values as incomplete
  2. add note about element id being in a different shadow DOM tree

autocomplete-valid:

  1. allow webauthn token
  2. allow webauthn token

avoid-inline-spacing:

  1. Add spacing threshold

axe.d.ts:

  1. updates type definition for Rule to add reviewOnFail

checks/label-content-name-mismatch:

  1. deprecate occuranceThreshold option in favor of occurrenceThreshold to fix typo

checks/no-focusable-disable:

  1. Don't count non-disableable elements as disabled

checks/unsupportedrole:

  1. Support unsupported dpub and fallback roles, add role to message

color-contrast:

  1. support CSS 4 color spaces
  2. correcly apply opacity to foreground color
  3. correctly calculate contrast of flex/grid items with z-index
  4. correctly compute background color for elements with opacity
  5. correctly compute color contrast of elements
  6. do not check contrast on elemets that are inerted
  7. skip ligature icons
  8. correctly compute color contrast of elements
  9. skip ligature icons
  10. fix color-contrast check when running in an extension
  11. consider -webkit-text-stroke & -webkit-text-fill-color
  12. correctly calculate background color of text nodes with different size than their container
  13. Correctly determine color contrast for element that exactly overlaps midpoint of node
  14. consistently return color contrast information in the data object for pseudo elements

color-contrast-enhanced:

  1. Avoid duplicates between color-contrast and color-contrast-enhanced

commons:

  1. deprecate flattenShadowColors in favor of flattenColors

context:

  1. allow selecting shadow DOM nodes

create-grid:

  1. correctly compute stack order for non-positioned stacking contexts
  2. include elements scrolled out of view in the grid

css-orientation-lock:

  1. support the css rotate property

d.ts:

  1. setup/teardown, reporters & metadata definitions
  2. add optional include to ContextObject

deprecatedrole,color-contrast:

  1. fix message to properly include deprecated role, improve color-contrast pass messages

dom.focusDisabled,dom.isVisibleForScreenreader:

  1. support the inert attribute

empty-table-headers:

  1. Rule is now best-practice and fails instead of incompletes

focus-order-semantics:

  1. Add ARIA role article to list of valid roles for scrollable regions

frame-focusable-content:

  1. don't fail for elements with negative tabindex

frame-title:

  1. Remove wcag241 tag
  2. ignore frames with negative tabindex (f61f825)
  3. return incomplete for presentational iframe with empty title

frame-title-unique:

  1. Make frame-title-unique reviewOnly and WCAG412

get-role:

  1. handle presentation role inheritance for vnodes with no parent

getRules:

  1. Return actIds when set

html-elms:

  1. update role allowances for nav element

html-lang-valid:

  1. only run rule when attribute has value

i18n:

  1. Add Norwegian Bokmål locale
  2. Add Hebrew translation

identical-links-same-purpose:

  1. Disable by default (wcag2aaa rule)

input-image-alt:

  1. Add the wcag412 tag

is-hidden-for-everyone:

  1. count elements inside closed details as hidden
  2. support content-visibility: hidden

is-icon-ligature:

  1. prevent canvas2d warning willReadFrequently

is-in-tab-order:

  1. Add isInTabOrder to commons

is-visible-on-screen:

  1. ignore elements hidden by overflow:hidden

label:

  1. avoid passing labels because of an input[value]

label,select-name:

  1. Remove the sc131 tag

link-in-text-block:

  1. set links with pseudo-content for review
  2. allow links with identical colors
  3. allow links with identical colors
  4. don't match style or script text
  5. Remove experimental and enable by default
  6. Update rule to match current guidance, revise tests

list,listitem:

  1. do not allow group as allowed parent or child

list/definition-list:

  1. Only allow required owned roles

meta-refresh:

  1. Add WCAG's 20-hour exception

meta-viewport:

  1. Report as violation of wcag 1.4.4

metadata:

  1. add Trusted Tester tag
  2. Map aria-required-children to ACT rule bc4a75
  3. Update ACT tags & actIds

new rule:

  1. Add WCAG 2.2 target-size rule (off by default)
  2. Add meta-refresh-no-exceptions (off by default, wcag2aaa)

no-autoplay-audio:

  1. add reviewOnFail and update tests

object-alt:

  1. ignore unloaded objects

page-has-heading-one,landmark-one-main:

  1. do not fail if modal is open

presentation-role-conflict:

  1. Test img elements with empty alt

required-attr:

  1. require aria-checked for checkbox-like and radio-like roles

respondable:

  1. work with CDP Page.setDocumentContent

scrollable-region-focusable:

  1. change impact to serious
  2. skip native controls
  3. skip native controls

standards:

  1. fix address typo in html-elms.js

tags:

  1. Add / correct several TTv5 tags

td-headers-attr:

  1. ignore hidden cells with headers attr
  2. ignore table elements with their role changed

utils:

  1. new shadowSelectAll utility
  2. greatly improve the speed of querySelectorAll

utils.matches:

  1. fix attribute exists selector to match empty attributes

valid-lang:

  1. ignore lang on elements with no text
  2. run on aria-hidden text

video-caption:

  1. remove excludeHidden: false

@Shubhabrata08
Copy link
Contributor Author

Changes in jest-axe from 6.0.1 to 8.0.0

  1. axe-core updated from 4.4.1 to 4.7.2
  2. chalk updated from 4.1.0 to 4.1.2
  3. jest-matcher utils updated from 27.0.2 to 29.2.2

Breaking changes

  1. axe-core includes new rules and checks
  2. axe-core help messages can cause snapshot diff
  3. Node js 10 and 12 are no longer supported

@AtishayMsft
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@fabricteam
Copy link
Collaborator

fabricteam commented Jan 15, 2024

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 634 652 5000
Button mount 301 302 5000
Field mount 1100 1162 5000
FluentProvider mount 686 709 5000
FluentProviderWithTheme mount 75 84 10
FluentProviderWithTheme virtual-rerender 68 65 10
FluentProviderWithTheme virtual-rerender-with-unmount 71 86 10
MakeStyles mount 863 862 50000
Persona mount 1774 1741 5000
SpinButton mount 1343 1396 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Jan 15, 2024

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AccordionMinimalPerf.default 89 74 1.2:1
ButtonMinimalPerf.default 98 86 1.14:1
LoaderMinimalPerf.default 209 183 1.14:1
ImageMinimalPerf.default 231 206 1.12:1
GridMinimalPerf.default 200 182 1.1:1
IconMinimalPerf.default 402 366 1.1:1
TreeWith60ListItems.default 89 81 1.1:1
ChatMinimalPerf.default 461 423 1.09:1
FormMinimalPerf.default 236 217 1.09:1
BoxMinimalPerf.default 208 193 1.08:1
AlertMinimalPerf.default 163 152 1.07:1
AvatarMinimalPerf.default 114 107 1.07:1
DatepickerMinimalPerf.default 3773 3535 1.07:1
CarouselMinimalPerf.default 263 248 1.06:1
ListNestedPerf.default 335 315 1.06:1
FlexMinimalPerf.default 162 155 1.05:1
LabelMinimalPerf.default 226 216 1.05:1
RefMinimalPerf.default 119 113 1.05:1
SegmentMinimalPerf.default 198 188 1.05:1
ItemLayoutMinimalPerf.default 724 699 1.04:1
SkeletonMinimalPerf.default 201 193 1.04:1
ChatWithPopoverPerf.default 196 191 1.03:1
HeaderMinimalPerf.default 206 200 1.03:1
InputMinimalPerf.default 546 528 1.03:1
TextMinimalPerf.default 193 187 1.03:1
ToolbarMinimalPerf.default 543 527 1.03:1
DividerMinimalPerf.default 205 200 1.02:1
DropdownMinimalPerf.default 1428 1395 1.02:1
HeaderSlotsPerf.default 473 464 1.02:1
ProviderMinimalPerf.default 201 197 1.02:1
SplitButtonMinimalPerf.default 2251 2207 1.02:1
VideoMinimalPerf.default 440 433 1.02:1
AttachmentMinimalPerf.default 82 81 1.01:1
ButtonSlotsPerf.default 304 301 1.01:1
DropdownManyItemsPerf.default 403 398 1.01:1
EmbedMinimalPerf.default 1858 1835 1.01:1
MenuMinimalPerf.default 505 502 1.01:1
MenuButtonMinimalPerf.default 943 934 1.01:1
PortalMinimalPerf.default 85 84 1.01:1
TableMinimalPerf.default 239 236 1.01:1
TextAreaMinimalPerf.default 279 275 1.01:1
TooltipMinimalPerf.default 1261 1247 1.01:1
ButtonOverridesMissPerf.default 657 660 1:1
CheckboxMinimalPerf.default 1114 1114 1:1
DialogMinimalPerf.default 430 432 1:1
LayoutMinimalPerf.default 194 194 1:1
ListMinimalPerf.default 306 305 1:1
SliderMinimalPerf.default 734 735 1:1
StatusMinimalPerf.default 396 395 1:1
CustomToolbarPrototype.default 1461 1459 1:1
ListCommonPerf.default 382 387 0.99:1
ProviderMergeThemesPerf.default 643 652 0.99:1
RadioGroupMinimalPerf.default 258 260 0.99:1
TableManyItemsPerf.default 1089 1098 0.99:1
TreeMinimalPerf.default 465 471 0.99:1
AnimationMinimalPerf.default 295 301 0.98:1
AttachmentSlotsPerf.default 622 636 0.98:1
ChatDuplicateMessagesPerf.default 145 150 0.97:1
RosterPerf.default 1522 1572 0.97:1
PopupMinimalPerf.default 346 360 0.96:1
ReactionMinimalPerf.default 218 228 0.96:1
CardMinimalPerf.default 301 317 0.95:1
ListWith60ListItems.default 342 364 0.94:1

@fabricteam
Copy link
Collaborator

fabricteam commented Jan 15, 2024

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext
510 B
328 B
global-context
createContextSelector
537 B
339 B
keyboard-key
keyboard-key package
3.746 kB
1.928 kB
priority-overflow
createOverflowManager
4.447 kB
1.853 kB
react
ActivityItem
68.833 kB
22.613 kB
react
Announced
36.473 kB
12.628 kB
react
Autofill
15.365 kB
4.743 kB
react
Breadcrumb
196.083 kB
58.757 kB
react
Button
190.127 kB
55.019 kB
react
ButtonGrid
175.918 kB
53.25 kB
react
Calendar
118.756 kB
36.101 kB
react
Callout
80.866 kB
26.564 kB
react
Check
51.062 kB
17.152 kB
react
Checkbox
57.791 kB
19.17 kB
react
ChoiceGroup
63.339 kB
20.824 kB
react
ChoiceGroupOption
56.601 kB
18.695 kB
react
Coachmark
89.704 kB
28.407 kB
react
Color
7.737 kB
3.106 kB
react
ColorPicker
129.984 kB
40.589 kB
react
ComboBox
245.355 kB
70.51 kB
react
CommandBar
197.362 kB
58.46 kB
react
ContextualMenu
150.967 kB
46.982 kB
react
DatePicker
180.318 kB
54.947 kB
react
DateTimeUtilities
5.244 kB
1.849 kB
react
DetailsList
225.886 kB
64.647 kB
react
Dialog
205.294 kB
61.428 kB
react
Divider
17.63 kB
6.234 kB
react
DocumentCard
211.08 kB
62.793 kB
react
DragDrop
8.343 kB
2.724 kB
react
DraggableZone
33.345 kB
11.166 kB
react
Dropdown
227.732 kB
66.867 kB
react
ExtendedPicker
94.987 kB
27.297 kB
react
Fabric
39.75 kB
13.688 kB
react
Facepile
205.992 kB
61.67 kB
react
FloatingPicker
236.233 kB
67.368 kB
react
FocusTrapZone
15.831 kB
5.54 kB
react
FocusZone
53.259 kB
16.869 kB
react
Grid
175.918 kB
53.25 kB
react
GroupedList
131.636 kB
39.657 kB
react
GroupedListV2
119.324 kB
36.822 kB
react
HoverCard
93.735 kB
29.778 kB
react
Icon
49.74 kB
16.603 kB
react
Icons
65.829 kB
24.212 kB
react
Image
44.79 kB
15.024 kB
react
Keytip
78.588 kB
25.825 kB
react
KeytipData
13.585 kB
4.418 kB
react
KeytipLayer
100.422 kB
31.128 kB
react
Keytips
103.175 kB
32.07 kB
react
Label
36.347 kB
12.639 kB
react
Layer
45.683 kB
15.585 kB
react
Link
37.673 kB
12.993 kB
react
List
38.136 kB
12.004 kB
react
MarqueeSelection
72.119 kB
21.676 kB
react
MessageBar
184.707 kB
55.523 kB
react
Modal
90.409 kB
29.213 kB
react
Nav
183.442 kB
55.093 kB
react
OverflowSet
31.044 kB
10.593 kB
react
Overlay
38.784 kB
13.401 kB
react
Panel
194.946 kB
58.34 kB
react
Persona
111.705 kB
35.58 kB
react
PersonaCoin
111.705 kB
35.58 kB
react
PersonaPresence
55.928 kB
18.715 kB
react
Pickers
287.603 kB
80.607 kB
react
Pivot
184.252 kB
55.823 kB
react
Popup
12.032 kB
4.114 kB
react
Positioning
21.821 kB
7.334 kB
react
PositioningContainer
70.754 kB
22.84 kB
react
ProgressIndicator
37.498 kB
12.906 kB
react
Rating
78.989 kB
25.18 kB
react
ResizeGroup
13.286 kB
4.365 kB
react
ResponsiveMode
8.078 kB
2.95 kB
react
ScrollablePane
53.538 kB
17.113 kB
react
SearchBox
182.982 kB
55.1 kB
react
SelectableOption
724 B
413 B
react
SelectedItemsList
226.659 kB
66.321 kB
react
Selection
41.202 kB
11.839 kB
react
Separator
33.397 kB
11.529 kB
react
Shimmer
47.265 kB
15.632 kB
react
ShimmeredDetailsList
236.654 kB
67.42 kB
react
Slider
55.575 kB
18.574 kB
react
SpinButton
186.661 kB
56.205 kB
react
Spinner
39.691 kB
13.815 kB
react
Stack
40.761 kB
13.931 kB
react
Sticky
32.064 kB
10.324 kB
react
Styling
44.812 kB
14.688 kB
react
SwatchColorPicker
186.166 kB
56.724 kB
react
TeachingBubble
200.004 kB
59.345 kB
react
Text
35.931 kB
12.486 kB
react
TextField
78.587 kB
24.642 kB
react
Theme
42.456 kB
13.773 kB
react
ThemeGenerator
12.34 kB
4.106 kB
react
TimePicker
235.197 kB
68.29 kB
react
Toggle
44.17 kB
15.346 kB
react
Tooltip
84.225 kB
27.277 kB
react
Utilities
71.851 kB
21.843 kB
react
Viewport
22.945 kB
7.292 kB
react
WeeklyDayPicker
98.762 kB
30.828 kB
react
WindowProvider
1.059 kB
541 B
react-accordion
Accordion (including children components)
100.127 kB
30.426 kB
react-alert
Alert
83.737 kB
23.474 kB
react-avatar
Avatar
50.175 kB
15.944 kB
react-avatar
AvatarGroup
19.704 kB
7.796 kB
react-avatar
AvatarGroupItem
64.831 kB
20.274 kB
react-badge
Badge
26.905 kB
8.729 kB
react-badge
CounterBadge
27.806 kB
9.024 kB
react-badge
PresenceBadge
25.311 kB
9.306 kB
react-breadcrumb
@fluentui/react-breadcrumb - package
115.48 kB
31.84 kB
react-button
Button
39.513 kB
11.169 kB
react-button
CompoundButton
46.874 kB
12.661 kB
react-button
MenuButton
44.292 kB
12.542 kB
react-button
SplitButton
52.306 kB
14.134 kB
react-button
ToggleButton
56.559 kB
13.068 kB
react-calendar-compat
Calendar Compat
152.073 kB
39.83 kB
react-card
Card - All
101.557 kB
28.932 kB
react-card
Card
96.382 kB
27.401 kB
react-card
CardFooter
13.064 kB
5.385 kB
react-card
CardHeader
15.307 kB
6.143 kB
react-card
CardPreview
14.015 kB
5.752 kB
react-checkbox
Checkbox
35.656 kB
12.07 kB
react-combobox
Combobox (including child components)
102.463 kB
33.101 kB
react-combobox
Dropdown (including child components)
103.837 kB
33.038 kB
react-components
react-components: Button, FluentProvider & webLightTheme
70.732 kB
20.465 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
217.207 kB
61.943 kB
react-components
react-components: FluentProvider & webLightTheme
43.219 kB
14.299 kB
react-datepicker-compat
DatePicker Compat
224.523 kB
62.939 kB
react-dialog
Dialog (including children components)
100.93 kB
29.924 kB
react-divider
Divider
20.82 kB
7.763 kB
react-field
Field
22.542 kB
8.608 kB
react-image
Image
15.745 kB
6.23 kB
react-infobutton
InfoButton
138.696 kB
43.398 kB
react-infobutton
InfoLabel
142.497 kB
44.627 kB
react-input
Input
26.891 kB
9.119 kB
react-jsx-runtime
Classic Pragma
1.057 kB
530 B
react-jsx-runtime
JSX Dev Runtime
3.783 kB
1.648 kB
react-jsx-runtime
JSX Runtime
4.377 kB
1.881 kB
react-label
Label
14.266 kB
5.828 kB
react-link
Link
17.082 kB
6.911 kB
react-menu
Menu (including children components)
149.428 kB
45.509 kB
react-menu
Menu (including selectable components)
152.114 kB
46.021 kB
react-message-bar
MessageBar (all components)
25.566 kB
9.131 kB
react-northstar
Accordion
85.357 kB
26.509 kB
react-northstar
Alert
87.425 kB
26.91 kB
react-northstar
Animation
55.304 kB
17.834 kB
react-northstar
Attachment
86.819 kB
26.7 kB
react-northstar
Avatar
80.254 kB
24.634 kB
react-northstar
Box
75.223 kB
23.814 kB
react-northstar
Breadcrumb
79.889 kB
24.707 kB
react-northstar
Button
83.135 kB
25.957 kB
react-northstar
Card
82.674 kB
25.027 kB
react-northstar
Carousel
105.15 kB
31.882 kB
react-northstar
Chat
152.326 kB
45.963 kB
react-northstar
Checkbox
79.782 kB
25.085 kB
react-northstar
Datepicker
184.887 kB
56.167 kB
react-northstar
Debug
8.801 kB
3.594 kB
react-northstar
Design
36.564 kB
12.07 kB
react-northstar
Dialog
112.02 kB
33.638 kB
react-northstar
Divider
76.594 kB
24.137 kB
react-northstar
Dropdown
196.43 kB
59.442 kB
react-northstar
Embed
81.446 kB
25.42 kB
react-northstar
Flex
47.702 kB
15.45 kB
react-northstar
Form
92.492 kB
28.881 kB
react-northstar
Grid
70.555 kB
22.283 kB
react-northstar
Header
74.731 kB
23.476 kB
react-northstar
Image
73.566 kB
23.339 kB
react-northstar
Input
88.31 kB
27.784 kB
react-northstar
ItemLayout
78.206 kB
24.458 kB
react-northstar
Label
77.895 kB
24.415 kB
react-northstar
Layout
75.368 kB
23.806 kB
react-northstar
List
88.472 kB
27.57 kB
react-northstar
Loader
78.591 kB
24.745 kB
react-northstar
Menu
126.85 kB
39.875 kB
react-northstar
MenuButton
161.254 kB
48.881 kB
react-northstar
Pill
83.697 kB
26.077 kB
react-northstar
Popup
133.56 kB
41.486 kB
react-northstar
Portal
58.294 kB
18.855 kB
react-northstar
Provider
93.114 kB
29.626 kB
react-northstar
RadioGroup
83.25 kB
26.056 kB
react-northstar
Reaction
77.255 kB
24.138 kB
react-northstar
Segment
76.184 kB
23.899 kB
react-northstar
Skeleton
77.74 kB
24.21 kB
react-northstar
Slider
84.235 kB
26.744 kB
react-northstar
SplitButton
176.487 kB
52.632 kB
react-northstar
Status
76.247 kB
24.059 kB
react-northstar
SvgIcon
36.819 kB
11.744 kB
react-northstar
Table
80.765 kB
25.159 kB
react-northstar
Text
74.089 kB
23.522 kB
react-northstar
TextArea
74.223 kB
23.501 kB
react-northstar
Toolbar
173.3 kB
52.087 kB
react-northstar
Tooltip
108.23 kB
34.491 kB
react-northstar
Tree
87.83 kB
27.223 kB
react-northstar
Video
75.379 kB
23.794 kB
react-overflow
hooks only
12.862 kB
4.827 kB
react-persona
Persona
57.066 kB
17.821 kB
react-popover
Popover
126.886 kB
39.806 kB
react-portal
Portal
13.633 kB
4.869 kB
react-portal-compat
PortalCompatProvider
7.944 kB
2.588 kB
react-positioning
usePositioning
26.398 kB
9.539 kB
react-progress
ProgressBar
17.428 kB
6.898 kB
react-provider
FluentProvider
23.759 kB
8.657 kB
react-radio
Radio
32.95 kB
10.251 kB
react-radio
RadioGroup
15.354 kB
6.265 kB
react-select
Select
28.609 kB
10.205 kB
react-slider
Slider
39.949 kB
12.968 kB
react-spinbutton
SpinButton
36.774 kB
11.788 kB
react-spinner
Spinner
23.517 kB
8.512 kB
react-switch
Switch
35.14 kB
11.2 kB
react-table
DataGrid
165.168 kB
45.902 kB
react-table
Table (Primitives only)
45.324 kB
14.116 kB
react-table
Table as DataGrid
136.55 kB
36.811 kB
react-table
Table (Selection only)
76.311 kB
20.546 kB
react-table
Table (Sort only)
74.977 kB
20.154 kB
react-tags
InteractionTag
15.259 kB
6.058 kB
react-tags
Tag
29.982 kB
9.439 kB
react-tags
TagGroup
80.556 kB
24.027 kB
react-text
Text - Default
16.705 kB
6.569 kB
react-text
Text - Wrappers
19.878 kB
6.896 kB
react-textarea
Textarea
30.947 kB
10.476 kB
react-theme
Single theme token import
69 B
89 B
react-theme
Teams: all themes
34.616 kB
7.317 kB
react-theme
Teams: Light theme
19.287 kB
5.498 kB
react-timepicker-compat
TimePicker
104.484 kB
34.49 kB
react-toast
Toast (including Toaster)
100.198 kB
29.76 kB
react-tooltip
Tooltip
54.58 kB
19.188 kB
react-utilities
SSRProvider
180 B
160 B
🤖 This report was generated against 068ebb4e8219f22513a5a90e0fe5d2ca1a04aa25

Copy link

size-auditor bot commented Jan 15, 2024

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 28dc7702fd80cb04c6b0cf7617d55ba5213616e3 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Jan 15, 2024

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 621 625 5000
Breadcrumb mount 1667 1667 1000
Checkbox mount 1658 1677 5000
CheckboxBase mount 1518 1456 5000
ChoiceGroup mount 2938 2982 5000
ComboBox mount 656 642 1000
CommandBar mount 6189 6202 1000
ContextualMenu mount 12210 12193 1000
DefaultButton mount 736 753 5000
DetailsRow mount 2179 2182 5000
DetailsRowFast mount 2241 2176 5000
DetailsRowNoStyles mount 2029 2063 5000
Dialog mount 2807 2632 1000
DocumentCardTitle mount 226 221 1000
Dropdown mount 1973 1962 5000
FocusTrapZone mount 1160 1120 5000
FocusZone mount 1066 1093 5000
GroupedList mount 41626 41476 2
GroupedList virtual-rerender 19962 19913 2
GroupedList virtual-rerender-with-unmount 50739 50663 2
GroupedListV2 mount 235 216 2
GroupedListV2 virtual-rerender 212 209 2
GroupedListV2 virtual-rerender-with-unmount 218 228 2
IconButton mount 1080 1066 5000
Label mount 333 333 5000
Layer mount 2734 2771 5000
Link mount 392 400 5000
MenuButton mount 968 945 5000
MessageBar mount 21497 21521 5000
Nav mount 1910 1909 1000
OverflowSet mount 773 798 5000
Panel mount 1777 1800 1000
Persona mount 721 753 1000
Pivot mount 874 862 1000
PrimaryButton mount 847 857 5000
Rating mount 4595 4608 5000
SearchBox mount 924 899 5000
Shimmer mount 1845 1898 5000
Slider mount 1329 1300 5000
SpinButton mount 2864 2902 5000
Spinner mount 406 383 5000
SplitButton mount 1793 1827 5000
Stack mount 407 417 5000
StackWithIntrinsicChildren mount 846 867 5000
StackWithTextChildren mount 2591 2563 5000
SwatchColorPicker mount 6116 6021 5000
TagPicker mount 1433 1468 5000
Text mount 366 372 5000
TextField mount 924 936 5000
ThemeProvider mount 817 818 5000
ThemeProvider virtual-rerender 601 580 5000
ThemeProvider virtual-rerender-with-unmount 1281 1287 5000
Toggle mount 618 614 5000
buttonNative mount 193 199 5000

yarn.lock Outdated Show resolved Hide resolved
@AtishayMsft
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@AtishayMsft
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@Shubhabrata08 Shubhabrata08 marked this pull request as ready for review January 17, 2024 07:20
@Shubhabrata08 Shubhabrata08 requested review from a team as code owners January 17, 2024 07:20
package.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
Co-authored-by: Martin Hochel <hochelmartin@gmail.com>
@AtishayMsft
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@AtishayMsft
Copy link
Contributor

@Shubhabrata08 Could you pull latest master and resolve the merge conflict

@Shubhabrata08
Copy link
Contributor Author

Ok

@Shubhabrata08
Copy link
Contributor Author

@AtishayMsft Merged latest changes

@AtishayMsft
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@fabricteam
Copy link
Collaborator

🕵 fluentuiv8 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

🕵 fluentuiv9 No visual regressions between this PR and main

@AtishayMsft AtishayMsft merged commit 4596285 into microsoft:master Feb 29, 2024
21 checks passed
@AtishayMsft
Copy link
Contributor

@Shubhabrata08 This change is merged now. Thanks for the contribution.

@Shubhabrata08
Copy link
Contributor Author

Happy to help 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants