Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitChanges/gitDiff don't handle moves #901

Open
sandersn opened this issue Jan 11, 2024 · 0 comments
Open

gitChanges/gitDiff don't handle moves #901

sandersn opened this issue Jan 11, 2024 · 0 comments

Comments

@sandersn
Copy link
Member

gitDiff doesn't parse the move format correctly (Rnnn fromPath toPath) and gitChanges treats unknown specifiers as adds. Together the two incorrectly treat moves as adds to the old location, which is precisely backward.

Discovered in DefinitelyTyped/DefinitelyTyped#68154; whole-package moves are the least common operation on DT, which is probably why we didn't think to test them, and why it took a month for someday to hit this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant