Inner classes with builder don't get introspected #11313
Merged
+151
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graemerocher
added
type: improvement
graemerocher
added
type: bug
|
yawkat
approved these changes
Nov 7, 2024
dstepanov
approved these changes
Nov 8, 2024
PeterFokkinga
pushed a commit
to PeterFokkinga/micronaut-core
that referenced
this pull request
Nov 22, 2024
…#11313) When an inner class is postponed to the next round the binary class name is used to perform a lookup of the refreshed class when processing gets to the next round. This is an issue because the canonical class name needs to be use to lookup elements. This changes the code to use `getCanonicalName()` which revealed another bug where the implementation of `JavaClassElement.getCanonicalName()` was not correct. --------- Co-authored-by: Graeme Rocher <graeme.rocher@oracle.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an inner class is postponed to the next round the binary class name is used to perform a lookup of the refreshed class when processing gets to the next round. This is an issue because the canonical class name needs to be use to lookup elements. This changes the code to use
getCanonicalName()which revealed another bug where the implementation ofJavaClassElement.getCanonicalName()was not correct.