deprecate HttpResponse::getStatus #11284
Merged
+19
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull-request deprecates `HttpResponse::getStatus` and `HttpClientResponseException::getStatus`. It adds `HttpClientResponseException::code`, and `HttpClientResponseException::reason` methods. In order to be custom status codes compatible is better for people to use `HttpResponse::code` instead of `HttpResponse::getStatus`. For example, we hit an issue in Micrometer micronaut-projects/micronaut-micrometer#857 I have annotated the method as deprecated but not for removal. I don’t think we should remove it as it will break a lot of apps and tests.
|
I think this will be a large and disruptive deprecation for a lot of codebases. Not sure it is worth deprecating to be honest |
|
I think we should avoid getStatus in framework code, but for most users, it's not really a problem to use because they don't use custom status types in the first place. |
The problem is how to convey this to @micronaut-projects/core-developers without deprecating it. |
sdelamo
commented
Oct 30, 2024
...ient-core/src/main/java/io/micronaut/http/client/exceptions/HttpClientResponseException.java
Outdated
Show resolved
Hide resolved
...ient-core/src/main/java/io/micronaut/http/client/exceptions/HttpClientResponseException.java
Outdated
Show resolved
Hide resolved
…ions/HttpClientResponseException.java
…ions/HttpClientResponseException.java
|
@graemerocher @yawkat I have removed the deprecation but kept the javadoc clarifications. Can you re-review? |
n0tl3ss
approved these changes
Oct 30, 2024
|
yawkat
approved these changes
Oct 30, 2024
graemerocher
approved these changes
Oct 30, 2024
PeterFokkinga
pushed a commit
to PeterFokkinga/micronaut-core
that referenced
this pull request
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request deprecates
HttpResponse::getStatusandHttpClientResponseException::getStatus. It addsHttpClientResponseException::code, andHttpClientResponseException::reasonmethods.In order to be custom status codes compatible is better for people to use
HttpResponse::codeinstead ofHttpResponse::getStatus.For example, we hit an issue in Micrometer micronaut-projects/micronaut-micrometer#857
I have annotated the method as deprecated but not for removal. I don’t think we should remove it as it will break a lot of apps and tests.