Implement http-client error log for non-CompletableFuture responses

[yawkat]

Discussed in #10551

^{Originally posted by stefanos-kalantzis February 27, 2024}
Case in point:

micronaut-core/http-client-core/src/main/java/io/micronaut/http/client/interceptor/HttpClientIntroductionAdvice.java

Line 384 in 3fc45e7

LOG.debug("Client [{}] received HTTP error response: {}", declaringType.getName(), t.getMessage(), t);

[meetpatel0963]

Hello, I am new to micronaut-core and I would like to work on this issue. Is it still open?

[yawkat]

yes. go ahead.

[meetpatel0963]

Cool, Thanks! So, the http-client error log is already there for the case of COMPLETION_STAGE. And for the PUBLISHER case, the subscribers will be responsible to add the required logs in doOnError.

To add the similar log for the SYNCHRONOUS case, we can just wrap the code performing the blocking calls with try/catch, log the error and re-throw the exception to be handled by the outer catch block to centralize the error handling for all 3 cases.

Am I right? I am so sorry if the question sounds silly. Just want to make sure I understand the requirement correctly. Thank you in advance! 😄

[yawkat]

that seems sensible for the sync case. I think it is also worthwhile to add the doOnError you mention on our own, just like it's implemented for CompletableFuture.

[meetpatel0963]

Thank you for the confirmation and the suggestion @yawkat. I'll get right to it.