Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to io.opentelemetry.semconv:opentelemetry-semconv #343

Closed
shakuzen opened this issue Sep 8, 2023 · 2 comments
Closed

Move to io.opentelemetry.semconv:opentelemetry-semconv #343

shakuzen opened this issue Sep 8, 2023 · 2 comments
Labels
breaking-change enhancement New feature or request
Milestone
1.2.0-RC1

Comments

@shakuzen
Copy link
Member

shakuzen commented Sep 8, 2023 •
edited by jonatan-ivanov

io.opentelemetry:opentelemetry-semconv was moved to io.opentelemetry.semconv:opentelemetry-semconv and the former will be deprecated.

Edit: That will only impact 1.2.x though, not 1.1.x what this issue should be for.
Edit2: Moving to the new semconv artifact will be the problem of the next release (1.2.0-RC1) .

Originally posted by @jonatan-ivanov in #340 (comment)
@shakuzen shakuzen added this to the 1.2.0-M3 milestone Sep 8, 2023
@shakuzen shakuzen mentioned this issue Sep 8, 2023
Closed
@jonatan-ivanov jonatan-ivanov modified the milestones: 1.2.0-M3, 1.2.0-M4 Sep 11, 2023
wilkinsona added a commit to spring-projects/spring-boot that referenced this issue Sep 12, 2023
@wilkinsona
Suppress warnings until more to new semconv module
4ebee17 
OTel has deprecated their semconv module and introduced a new module
with different Maven coordinates. micrometer-metrics/tracing#343 will
move Micrometer Tracing to the new module. Until then, we need to
suppress the deprecation warnings that result from using the old one.

Closes gh-37347
@marcingrzejszczak
Copy link
Contributor

The way I did it is actually a breaking change cause we don't include the deprecated dependency anymore. @wilkinsona is this actually ok from point of view e.g. Boot or should we add both dependencies and remove the deprecated one in e.g. 1-2 minors?

@wilkinsona
Copy link

I'll have a better feel for it once we've moved to snapshots next week, but I think that's probably OK. My expectation is that anyone who really needs the deprecated one can add the dependency directly. We consider that kind of easily fixed problem to be fine for a new minor release of Boot.

@shakuzen shakuzen added the enhancement New feature or request label Oct 10, 2023
@conghuhu conghuhu mentioned this issue Nov 21, 2023
Closed
@brusdev brusdev mentioned this issue Jan 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change enhancement New feature or request
Projects
None yet
Milestone
1.2.0-RC1
Development

No branches or pull requests
4 participants
@wilkinsona @jonatan-ivanov @marcingrzejszczak @shakuzen