Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JavaDoc : Propagator references Open Telemetry classes which is not part of Micrometer #230

Closed
jjoslet opened this issue Apr 14, 2023 · 2 comments · Fixed by #236
Closed

JavaDoc : Propagator references Open Telemetry classes which is not part of Micrometer #230

jjoslet opened this issue Apr 14, 2023 · 2 comments · Fixed by #236
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed
Milestone
1.0.5

Comments

@jjoslet
Copy link
Contributor

jjoslet commented Apr 14, 2023

The JavaDoc in the Propagator class references TextMapPropagator from Open Telemetry which is not part of Micrometer.

This is present at line 96 and 133
@marcingrzejszczak
Copy link
Contributor

Nice catch! Are you willing to file PR with a fix to the 1.0.x branch? I would merge it forward afterwards.

@marcingrzejszczak marcingrzejszczak added documentation Improvements or additions to documentation good first issue Good for newcomers labels Apr 14, 2023
@jonatan-ivanov jonatan-ivanov added the help wanted Extra attention is needed label Apr 14, 2023
@jjoslet jjoslet mentioned this issue Apr 18, 2023
Merged
@shakuzen shakuzen added this to the 1.0.5 milestone Apr 19, 2023
@shakuzen shakuzen linked a pull request Apr 19, 2023 that will close this issue
Propagator JavaDoc references Open Telemetry #236
Merged
@shakuzen
Copy link
Member

Closed by #236

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
1.0.5
Development

Successfully merging a pull request may close this issue.

Propagator JavaDoc references Open Telemetry jjoslet/tracing
4 participants
@jonatan-ivanov @marcingrzejszczak @shakuzen @jjoslet