Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature parity with sleuth's annotations #163

Closed
dimi-nk opened this issue Feb 13, 2023 · 2 comments
Closed

Feature parity with sleuth's annotations #163

dimi-nk opened this issue Feb 13, 2023 · 2 comments
Assignees
@marcingrzejszczak
Labels
enhancement New feature or request
Milestone
1.1.0-M2

Comments

@dimi-nk
Copy link

dimi-nk commented Feb 13, 2023

Sleuth supported some annotations to declaratively extract tracing tags, e.g. @SpanTag, see sleuth. These annotations exist in micrometer tracing but are not yet implemented, according to @marcingrzejszczak. Could we please hook them up? :)
@marcingrzejszczak marcingrzejszczak added the enhancement New feature or request label Feb 15, 2023
@marcingrzejszczak marcingrzejszczak self-assigned this Mar 2, 2023
@marcingrzejszczak marcingrzejszczak mentioned this issue Mar 10, 2023
Closed
@marcingrzejszczak
Copy link
Contributor

Done via ca3241d

@marcingrzejszczak marcingrzejszczak added this to the 1.1.0-M2 milestone Mar 10, 2023
@dimi-nk
Copy link
Author

dimi-nk commented Mar 10, 2023

Amazing @marcingrzejszczak. Thanks for the quick resolution.

@Exidex Exidex mentioned this issue Jun 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcingrzejszczak marcingrzejszczak

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.1.0-M2
Development

Successfully merging a pull request may close this issue.

Annotation parity with Sleuth micrometer-metrics/tracing
2 participants
@dimi-nk @marcingrzejszczak