Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSGi import of javax.annotation and javax.annotation.meta is incorrect #4824

Closed
ponziani opened this issue Mar 4, 2024 · 1 comment · Fixed by #4825
Closed

OSGi import of javax.annotation and javax.annotation.meta is incorrect #4824

ponziani opened this issue Mar 4, 2024 · 1 comment · Fixed by #4825
Labels
bug A general bug module: micrometer-common An issue that is related to our common module module: micrometer-core An issue that is related to our core module
Milestone
1.11.10

Comments

@ponziani
Copy link
Contributor

ponziani commented Mar 4, 2024

Describe the bug
The manifest file of micrometer-core and micrometer-commons contains the Import-Package "javax.annotation;version=
"[3.0,4)",javax.annotation.meta;version="[3.0,4)". However, these are not the correct version ranges, as explained in https://github.com/jhy/jsoup/issues/1616#issuecomment-958684482

This results in our Apache Karaf application no longer starting after upgrading to Micrometer 1.11

Caused by: org.apache.felix.resolver.reason.ReasonException: Unable to resolve micrometer-commons/1.11.9: missing requirement [micrometer-commons/1.11.9] osgi.wiring.package; filter:="(&(osgi.wiring.package=javax.annotation)(version>=3.0.0)(!(version>=4.0.0)))" at org.apache.felix.resolver.Candidates$MissingRequirementError.toException(Candidates.java:1341) ... 17 more

Environment

  • Micrometer version 1.11.9
  • Java version: 17

Additional context
As suggested in the jsoup-link, the import could be made optional.
ponziani pushed a commit to ponziani/micrometer that referenced this issue Mar 4, 2024
OSGi import of javax.annotation and javax.annotation.meta is incorrect …
a36b0bb 
…micrometer-metrics#4824
@ponziani ponziani mentioned this issue Mar 4, 2024
Merged
@shakuzen shakuzen added bug A general bug module: micrometer-core An issue that is related to our core module module: micrometer-common An issue that is related to our common module and removed waiting-for-triage labels Mar 5, 2024
@shakuzen shakuzen modified the milestones: 1.11.x, 1.11.10 Mar 5, 2024
shakuzen pushed a commit to ponziani/micrometer that referenced this issue Mar 11, 2024
@shakuzen
OSGi import of javax.annotation and javax.annotation.meta is incorrect …
c0438f6 
…micrometer-metrics#4824
shakuzen pushed a commit that referenced this issue Mar 11, 2024
@ponziani
OSGi import of javax.annotation and javax.annotation.meta is incorrect …
37bfdfd 
…#4824 (#4825)

Co-authored-by: shu <steven.huypens@cipalschaubroeck.be>
@shakuzen shakuzen linked a pull request Mar 11, 2024 that will close this issue
OSGi import of javax.annotation is incorrect #4824 #4825
Merged
@shakuzen
Copy link
Member

Resolved by #4825

essobedo added a commit to jbonofre/camel-karaf that referenced this issue Mar 25, 2024
@essobedo
Bump micrometer from 1.12.3 to 1.12.4
cc364e4 
Includes a fix for micrometer-metrics/micrometer#4824
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A general bug module: micrometer-common An issue that is related to our common module module: micrometer-core An issue that is related to our core module
Projects
None yet
Milestone
1.11.10
Development

Successfully merging a pull request may close this issue.

OSGi import of javax.annotation is incorrect #4824 ponziani/micrometer
2 participants
@shakuzen @ponziani