Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support generational ZGC #4258

Closed
shakuzen opened this issue Oct 18, 2023 · 1 comment
Closed

Support generational ZGC #4258

shakuzen opened this issue Oct 18, 2023 · 1 comment
Assignees
@shakuzen
Labels
enhancement A general enhancement module: micrometer-core An issue that is related to our core module
Milestone
1.12.0

Comments

@shakuzen
Copy link
Member

shakuzen commented Oct 18, 2023 •
edited

JEP 439 added support for generational ZGC. We should make sure our GC metrics work well with that.
@shakuzen shakuzen added the enhancement A general enhancement label Oct 18, 2023
@shakuzen shakuzen added this to the 1.12.0 milestone Oct 18, 2023
@shakuzen shakuzen self-assigned this Oct 18, 2023
@shakuzen
Copy link
Member Author

The names of the GarbageCollectorMXBeans are

  • ZGC Minor Cycles
  • ZGC Minor Pauses
  • ZGC Major Cycles
  • ZGC Major Pauses

Note that the "Pauses" collectors do not have info about memory size. See #2872.

MemoryPool names are:

  • ZGC Young Generation
  • ZGC Old Generation

@shakuzen shakuzen added the module: micrometer-core An issue that is related to our core module label Oct 20, 2023
@shakuzen shakuzen mentioned this issue Oct 20, 2023
Open
@shakuzen shakuzen mentioned this issue Feb 28, 2024
Closed
shakuzen added a commit that referenced this issue Feb 28, 2024
@shakuzen
Count Generational ZGC cycles as concurrent time
39ef7ff 
This was missed when support for Generational ZGC was otherwise added in gh-4258. Non-generational ZGC uses the collector name `ZGC Cycles` for concurrent phases. Generational ZGC however uses `ZGC Minor Cycles` and `ZGC Major Cycles` which was not included in prior conditional for ZGC.

This conditionally enables a previously disabled test and makes sure it accounts for any GC that happens before metrics are recorded. It only works with a limited number of collectors (ZGC and Shenandoah) but it would have caught this issue and will ensure we don't introduce regressions.

Resolves gh-4764
@srknzl srknzl mentioned this issue May 17, 2024
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shakuzen shakuzen

Labels
enhancement A general enhancement module: micrometer-core An issue that is related to our core module
Projects
None yet
Milestone
1.12.0
Development

No branches or pull requests
1 participant
@shakuzen