Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable base time unit for OTLP registry #3870

Closed
shakuzen opened this issue May 31, 2023 · 2 comments · Fixed by #3883
Closed

Configurable base time unit for OTLP registry #3870

shakuzen opened this issue May 31, 2023 · 2 comments · Fixed by #3883
Labels
enhancement A general enhancement registry: otlp OpenTelemetry Protocol (OTLP) registry-related spring-boot change Change is needed in Spring Boot for this issue
Milestone

Comments

@shakuzen
Copy link
Member

We avoid making the base time unit configurable because it can lead to nasty issues if different applications are producing metrics data for the same meters in different units. However, it doesn't look hopeful open-telemetry/opentelemetry-collector-contrib#18903 is going to be resolved, and it's also not great that data from the OTLP registry through the Collector to Prometheus is going to have a different unit than everything else Prometheus scrapes (presumably, since Prometheus asks producers to use seconds for time).

We'll have to discuss this and what, if anything, it makes sense for us to do in Micrometer.

@shakuzen shakuzen added enhancement A general enhancement waiting for team An issue we need members of the team to review registry: otlp OpenTelemetry Protocol (OTLP) registry-related labels May 31, 2023
@shakuzen shakuzen added this to the 1.12 backlog milestone May 31, 2023
@zeitlinger
Copy link
Contributor

I also ran into this issue today - and created a PR - based on the assumption that this is meeting the spec

@jonatan-ivanov jonatan-ivanov added the spring-boot change Change is needed in Spring Boot for this issue label Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A general enhancement registry: otlp OpenTelemetry Protocol (OTLP) registry-related spring-boot change Change is needed in Spring Boot for this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants