Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Child observation should be noop if parent is noop #3850

Open
marcingrzejszczak opened this issue May 19, 2023 · 1 comment
Open

Child observation should be noop if parent is noop #3850

marcingrzejszczak opened this issue May 19, 2023 · 1 comment
Labels
module: micrometer-observation waiting for team An issue we need members of the team to review

Comments

@marcingrzejszczak
Copy link
Contributor

If an ObservationPredicate "disables" an observation it's a NOOP observation. Now, when the child Observation is created and its parent is NOOP then we should make that observation NOOP too.

@jonatan-ivanov
Copy link
Member

jonatan-ivanov commented May 19, 2023

There are quite a few related issues around this:

But I'm not quite sure that this behavior would be right, I think ignoring an intermediate Observation without ignoring all of the subsequent ones is a valid behavior, e.g.:

  • In case of A -> B -> C, I think ignoring B but keeping C should be valid: A -> C
  • In case of A -> B -> C, I think ignoring A but keeping B and C should be valid: B -> C

@jonatan-ivanov jonatan-ivanov added the waiting for team An issue we need members of the team to review label May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: micrometer-observation waiting for team An issue we need members of the team to review
Projects
None yet
Development

No branches or pull requests

2 participants