Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance Apache HttpComponents instrumentation to support the exception tag. #3812

Closed
cachescrubber opened this issue May 5, 2023 · 2 comments
Closed

Enhance Apache HttpComponents instrumentation to support the exception tag. #3812

cachescrubber opened this issue May 5, 2023 · 2 comments
Labels
superseded An issue that has been superseded by another

Comments

@cachescrubber
Copy link
Contributor

Please describe the feature request.
Enhance Apache HttpComponents instrumentation to support the exception tag.

Rationale
Most if not all the other http client / server based instrumentations support an exception Tag. For the sake of consistency, enable to HttpComponents instrumentation to support the exception tag.

Additional context
I'm happy to contribute. A PR would be blocked by #3800 since the HttpAsyncClient currently does not meter errors / IOExceptions.

Relates to #3729
@shakuzen shakuzen added enhancement A general enhancement help wanted An issue that a contributor can help us with module: micrometer-core An issue that is related to our core module and removed waiting-for-triage labels May 8, 2023
@shakuzen shakuzen added this to the 1.x milestone May 8, 2023
@shakuzen shakuzen added the instrumentation An issue that is related to instrumenting a component label May 8, 2023
@cachescrubber cachescrubber mentioned this issue May 16, 2023
Closed
@izeye
Copy link
Contributor

izeye commented Aug 19, 2023

This seems to have been covered through #3800 already.

@cachescrubber
Copy link
Contributor Author

Yes, closed with #3800 for http client 5.

@jonatan-ivanov jonatan-ivanov closed this as not planned Won't fix, can't repro, duplicate, stale Sep 7, 2023
@jonatan-ivanov jonatan-ivanov removed this from the 1.x milestone Sep 7, 2023
@jonatan-ivanov jonatan-ivanov added superseded An issue that has been superseded by another and removed enhancement A general enhancement help wanted An issue that a contributor can help us with module: micrometer-core An issue that is related to our core module instrumentation An issue that is related to instrumenting a component labels Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
superseded An issue that has been superseded by another
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@izeye @jonatan-ivanov @cachescrubber @shakuzen