Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

per-rule file exclude filters (#850) #857

Merged
merged 4 commits into from
Aug 12, 2023

Conversation

comdiv
Copy link
Contributor

@comdiv comdiv commented Aug 5, 2023

Rule-level file exclude filter feature implementation #850

Tryed to keep project at max compatibility level.

But where are some changes in core structures.

Filters are prechecked and initialized after reading from TOML, so it could cause error.
So Initialize() error method added to RuleConfig

Logically it should be applyed in normalize... part of GetConfig, but just parse can return error, not normalize, so
added call of initialization to parse part of GetConfig

All tested.

Closes #850

@chavacava chavacava merged commit 310d1d7 into mgechev:master Aug 12, 2023
8 checks passed
@chavacava
Copy link
Collaborator

Hi @comdiv, thanks for the PR !
(I've modified the semantics of the ""exclusion pattern to match nothing )

@comdiv
Copy link
Contributor Author

comdiv commented Aug 12, 2023

Hi @comdiv, thanks for the PR ! (I've modified the semantics of the ""exclusion pattern to match nothing )

OK, it's well semantic too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Glob/regex file excludes at rule level
2 participants