Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support method call from structures for string-format #840

Merged
merged 2 commits into from
Jul 29, 2023

Conversation

rmarku
Copy link
Contributor

@rmarku rmarku commented Jun 12, 2023

This MR fix issue #839. Here the called object method is inside a structure (common pattern for dependency injection). Before the rule was not running for this rules.

The only thing is the function scope is tied to the structure name of the object, not to the object name.

This MR tries to fix this. A test was added to the string-format to evaluate this.

  • Did you add tests?
  • Does your code follows the coding style of the rest of the repository?
  • Does the Travis build passes?

Closes #839

@chavacava
Copy link
Collaborator

Hi @rmarku thanks for the PR!

(abrazo de un santiagueño a un tucumano)

@chavacava chavacava merged commit a155d92 into mgechev:master Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

string-format rule not working on method called when obj is inside an struct.
2 participants