-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emit hdf5 version as a build constant #48
Conversation
9b6657a
to
3664338
Compare
thanks for the fast response, this is awesome! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to include your repo in my project with
hdf5 = {git = "https://github.com/magnusuMET/hdf5-rust.git", branch = 'const_hdf5_version'}
but I get the following error:
error: no matching package named `hdf5` found
location searched: Git repository https://github.com/magnusuMET/hdf5-rust.git?branch=const_hdf5_version
I have the feeling that this might be because the hdf
package does not exist in the default branch, but unsure.
Maybe you could rebase your default branch to update to the latest version?
Or not if thats too much work, to me the code looks ok as is, I can also test once its merged
Thanks again!
The package is named [patch.crates-io]
hdf5 = { package="hdf5-metno", git = "https://github.com/magnusuMET/hdf5-rust.git", branch = "const_hdf5_version" } |
907f94d
to
c61b7b1
Compare
now I got it to work, thanks! |
Thanks for suggesting this feature, it is released as |
Awesome |
Hopefully this works for you @philbucher. It is re-exported in
hdf5
and the version is visible in the generated docs.Fixes #47