Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chrome webstore url causing 404 #5352

Merged
merged 2 commits into from Mar 5, 2024
Merged

Conversation

Abrifq
Copy link
Contributor

@Abrifq Abrifq commented Mar 2, 2024

now it's "Too many redirects" like all of it's brethren 🙂

I should open a issue on lychee for this problem but also it's not their fault

idk, it's annoying, it's noise.

How do you guys filter it?

📑 Summary

Fixing one link that had a slash at the end of it. Turns out new chrome webstore doesn't like that!

Resolves my pet peeves, for now.

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

now it's "Too many redirects" like all of it's brethren 🙂
Copy link

netlify bot commented Mar 2, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 2537bf5
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/65e372fc9896960008055e67
😎 Deploy Preview https://deploy-preview-5352--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Mar 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.22%. Comparing base (2ac4e08) to head (2537bf5).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #5352       +/-   ##
============================================
+ Coverage    43.37%   79.22%   +35.85%     
============================================
  Files           23      175      +152     
  Lines         5130    14531     +9401     
  Branches        23      868      +845     
============================================
+ Hits          2225    11512     +9287     
+ Misses        2904     2816       -88     
- Partials         1      203      +202     
Flag Coverage Δ
e2e 84.79% <ø> (?)
unit 43.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 170 files with indirect coverage changes

Wait, it complained about a table in markdown?
Why??
@sidharthv96 sidharthv96 merged commit 82fd371 into mermaid-js:develop Mar 5, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants