Bump @zenuml/core and update render options in mermaid-zenuml #5257
Conversation
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5257 +/- ##
========================================
Coverage 43.22% 43.22%
========================================
Files 23 23
Lines 5037 5037
Branches 23 23
========================================
Hits 2177 2177
Misses 2859 2859
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Hi @sidharthv96, the pipeline failed due to discrepancies in visual testing. These differences are expected since we made minor changes to the diagram styles. Can you advise on how I could update the snapshots? Thanks |
|
Currently in GH Actions, we rely on images taken directly from the run of target branch, so there is no way to update the snapshots. I'll verify the failures and merge it if there are no other issues :) Can you please resolve the merge conflicts? |
dontry
force-pushed
the
feature/upgrade-zenuml-package
branch
from
7d6af74
to
de5f59c
Compare
|
@sidharthv96 I've resolved the conflicts. Could you have a look again? Thanks heaps. |
|
@dontry, Thank you for the contribution! |
* develop: (124 commits) chore(deps): update all patch dependencies fix typo cutomers => customers chore(deps): update all minor dependencies Fix macOS onboarding issues Bump @zenuml/core and update render options in mermaid-zenuml (#5257) Fixed Typo in ErrorRenderer.ts (#5256) #3358 Removing redundant file #3358 Fix after review Fix selector #3358 Renaming of IOperation to ActionFun chore: Add interface naming build(deps-dev): bump vite from 4.4.12 to 4.5.2 Update container Update container Remove pnpm cache 3358 Adding types for blockArrowHelper #3358n Updated lockfile Update docs #3358 Another set of review changes Use `.node-version` file in workflows ...
* next: (118 commits) Update Deps chore(deps): update all patch dependencies fix typo cutomers => customers chore(deps): update all minor dependencies Fix macOS onboarding issues Bump @zenuml/core and update render options in mermaid-zenuml (mermaid-js#5257) Fixed Typo in ErrorRenderer.ts (mermaid-js#5256) mermaid-js#3358 Removing redundant file mermaid-js#3358 Fix after review Fix selector mermaid-js#3358 Renaming of IOperation to ActionFun chore: Add interface naming build(deps-dev): bump vite from 4.4.12 to 4.5.2 Update container Update container Remove pnpm cache 3358 Adding types for blockArrowHelper #3358n Updated lockfile Update docs mermaid-js#3358 Another set of review changes ...
📑 Summary
This PR bumps @zenuml/core dependency for mermaid-zenuml package and updates the zenuml render options.
📏 Design Decisions
This PR aims to resolve the mermaid-zenuml render issue introduced by the incompatibility of new versions.
Before
After
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.developbranch