fix(types): correct rootDir
in tsconfig.json
#804
Merged
+1
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
It looks like the default
rootDir
was"."
, but for some reason, adding thesrc/version.js
file changed therootDir
to"./src/"
.I'm not sure why this is, looking at the TypeScript
tsconfig
reference docs forrootDir
: https://www.typescriptlang.org/tsconfig/#rootDir, they say:Which should have already been
./src/
?Regardless, I've explicitly set
rootDir: "."
to generate the types atdist-types/src/index.d.ts
instead of thedist-types/index.d.ts
it's being exported to since 9a42e3c.Fixes: 9a42e3c
Fixes: #803
📏 Design Decisions
N/A
📋 Tasks
Make sure you
master
branch