Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle backpressure in subscriptions #1136

Merged
merged 1 commit into from
Feb 24, 2025
Merged

Handle backpressure in subscriptions #1136

merged 1 commit into from
Feb 24, 2025
+52 −25

Conversation

mcollina
Copy link
Collaborator

No description provided.

@mcollina
Handle backpressure in subscriptions
Loading
Loading status checks…
1461412 
Signed-off-by: Matteo Collina <hello@matteocollina.com>
@mcollina mcollina requested a review from jonnydgreen February 24, 2025 08:29
@mcollina mcollina requested a review from simoneb February 24, 2025 09:22
simoneb
simoneb approved these changes Feb 24, 2025
View reviewed changes
Copy link
Collaborator

@simoneb simoneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, simple enough. If I understand correctly, you're simply delegating the responsibility of managing the backpressure to the socket by using its callback function, which I guess is what tells you: go ahead, I'm not pushing back

@mcollina
Copy link
Collaborator Author

Yes exactly. Luckily, ws.send has a callback (contrary to the spec one).

@mcollina mcollina merged commit ac32db6 into master Feb 24, 2025
14 checks passed
@mcollina mcollina deleted the handle-backpressure branch February 24, 2025 10:03
@jonnydgreen
Copy link
Contributor

Looks good and makes sense! Apologies, didn't see this in time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simoneb simoneb

@simone-sanfratello simone-sanfratello

@jonnydgreen jonnydgreen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mcollina @jonnydgreen @simoneb @simone-sanfratello