-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix code samples (remove useless, and add missing) #1580
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1580 +/- ##
=======================================
Coverage 97.25% 97.25%
=======================================
Files 22 22
Lines 765 765
Branches 108 108
=======================================
Hits 744 744
Misses 20 20
Partials 1 1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✨🦕
bors merge
1580: Fix code samples (remove useless, and add missing) r=mdubus a=curquiza I created [scripts to manage code samples](https://github.com/meilisearch/integration-automations/pull/164) (internal only) I found out the following code samples are still in this repo but not used by the documentation anymore: ```bash meilisearch-js - 'documents_guide_add_movie_1' not found in documentation - 'getting_started_communicating_with_a_protected_instance' not found in documentation - 'faceted_search_facets_1' not found in documentation - 'faceted_search_2' not found in documentation ``` And the missing code samples ``` meilisearch-js - 'getting_started_typo_tolerance' not found ``` I also changed some `"` into `'` 1582: Fix broken link in README.md r=mdubus a=curquiza Fixes #1581 Related to: meilisearch/documentation#2566 Co-authored-by: curquiza <clementine@meilisearch.com> Co-authored-by: Clémentine U. - curqui <clementine@meilisearch.com>
This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried. Additional information: {"message":"Changes must be made through a pull request.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
bors merge |
I created scripts to manage code samples (internal only)
I found out the following code samples are still in this repo but not used by the documentation anymore:
And the missing code samples
I also changed some
"
into'