Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move "call for peace" to README.md to avoid unintended consequences #199

Closed
rjwut-chg opened this issue Jul 21, 2023 · 1 comment
Closed

Comments

@rjwut-chg
Copy link

While I have zero issue with the intent of the message in question, using postinstall scripts is problematic. For security reasons, people shy away from packages that have postinstall scripts or disable such scripts, but the bigger issue is unintended consequences like #181, resulting in the package installation erroring out and failing builds. This is not an acceptable cost for functionality that has nothing to do with the package's purpose. Moving the "call for peace" message to the top of README.md would still retain high visibility, without the risks of using a postinstall script.

@medikoo
Copy link
Owner

medikoo commented Jul 24, 2023

@rjwut-chg let's keep discussion under #181, I'm reading all comments there (no need to create another issues)

@medikoo medikoo closed this as completed Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants