Don't parse ES syntax in open blocks #763
Merged
+23
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a block is open, such as a list or blockquote, we shouldn't attempt to parse import/export syntax. Related gatsbyjs/gatsby#17315
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://mdx-git-es-syntax-blocks.mdx.now.sh |
wooorm
approved these changes
Sep 3, 2019
|
@ChristopherBiscardi @johno @wooorm The error detail should be checked whether it is a syntax error. Example: import A from 'x'
import A from 'y'It should throw error instead of parsed as paragraph. You can check https://travis-ci.com/rx-ts/eslint-mdx/builds/125786664#L355 for detail. |
|
Hmm, yeah I guess we should revert the error catching piece 🤔 |
johno
added a commit
that referenced
this pull request
Sep 4, 2019
This also catches valid errors like duplicate imports so for now we shouldn't catch these. Related #763
johno
added a commit
that referenced
this pull request
Sep 4, 2019
This also catches valid errors like duplicate imports so for now we shouldn't catch these. Related #763
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a block is open, such as a list or blockquote,
we shouldn't attempt to parse import/export syntax.
Additionally, if a paragraph begins with import/export
and doesn't parse, we now make it a raw paragraph
node.
Related gatsbyjs/gatsby#17315