Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(macros/LearnSidebar): update titles for consistency #10773

Merged
merged 1 commit into from Mar 22, 2024

Conversation

dipikabh
Copy link
Contributor

Summary

This is a follow-up to the PR mdn/content#32643 (review)

Problem

  1. "Core forms learning pathway" - With the updated page title "Web form building blocks" (merged change), the menu drop-down header needs to be the same. So "Core forms learning pathway" should read "Web form building blocks" (as in HTML, CSS, and JavaScript sections of the Learn sidebar).
  2. "Advanced form articles" - The title needs to contain "web form" for consistency and we don't use "articles" in any of the other menus/titles.

Solution

  • "Core forms learning pathway" has been updated to "Web form building blocks"
  • "Advanced form articles" has been updated to "Advanced web form techniques"

Screenshots

Before After
before screenshot before screenshot

@dipikabh dipikabh requested a review from a team as a code owner March 22, 2024 15:51
@github-actions github-actions bot added the macros tracking issues related to kumascript macros label Mar 22, 2024
@caugner caugner changed the title fix(learnsidebar): Update titles for consistency fix(macros/LearnSidebar): update titles for consistency Mar 22, 2024
@caugner caugner merged commit b488d0f into mdn:main Mar 22, 2024
9 checks passed
@dipikabh
Copy link
Contributor Author

Thanks for reviewing and approving, @caugner!

@dipikabh dipikabh deleted the learn-sidebar-form branch March 22, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macros tracking issues related to kumascript macros
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants