Remove redundant subfeatures of CookieChangeEvent/CookieStore API #26152
+0
−912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes the unsupported subfeatures of the `CookieChangeEvent` and `CookieStore` APIs from BCD. This is duplicated data that can be found on api.CookieStore.get, so it is redundant.
queengooborg
added
the
data:api
caugner
reviewed
Mar 11, 2025
There was a problem hiding this comment.
It makes sense to reduce this duplication, but I would prefer to have a separate api.CookieListItem feature for the dictionary with all its properties, rather than keeping those under api.CookieStore.get.
caugner
added
the
meeting agenda
caugner
approved these changes
Mar 18, 2025
caugner
removed
the
meeting agenda
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the unsupported subfeatures of the
CookieChangeEventandCookieStoreAPIs from BCD. This is duplicated data that can be found on api.CookieStore.get, so it is redundant.