Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync_event is experimental like SyncEvent and SyncManager #22137

Merged
merged 3 commits into from
Mar 12, 2024

Conversation

sidewayss
Copy link
Contributor

@sidewayss sidewayss commented Feb 1, 2024

The docs say the ServiceWorkerGlobalScope "sync" event is type SyncEvent and depends on SyncManager, and both of those are experimental technology, so the "sync" event must be experimental too.

NOTE: the script has been flipped and now SyncEvent and SyncManager are not experimental. This PR reflects that change.

@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Feb 1, 2024
@skyclouds2001
Copy link
Contributor

per https://github.com/mdn/browser-compat-data/blob/main/docs/data-guidelines/index.md#setting-experimental, the Background Sync API could be mark as non-experiment, as they are supported by at least one platform and for more then two years (in fact it is eight years).

@sidewayss
Copy link
Contributor Author

By that logic SyncEvent and SyncManager should not be labeled experimental. I'm fine with that, so long as these 3 items are in sync, so to speak.

@skyclouds2001
Copy link
Contributor

Yes, you can change this PR to label both SyncEvent and SyncManager (and ServiceWorkerRegistration.sync) are not experimental

@queengooborg
Copy link
Collaborator

Yes, per the BCD guidelines, these features should be marked as non-experimental. @sidewayss, would you be down to change this PR (or create a new one) to mark SyncEvent and SyncManager as non-experimental instead?

@sidewayss
Copy link
Contributor Author

@sidewayss, would you be down to change this PR (or create a new one) to mark SyncEvent and SyncManager as non-experimental instead?

Sure, I'll try to get to it later today.

SyncEvent and SyncManager are *not* experimental.  But what about their properties/methods?
@sidewayss
Copy link
Contributor Author

sidewayss commented Mar 5, 2024

I modified this branch to remove my original change and make SyncEvent and SyncManager not experimental. I removed the experimental property from the SyncEvent constructor, but I'm not sure which other properties/methods of both of these to mark as non-experimental. That will require some review from you, @queengooborg. Feel free to make whatever changes those are and merge, otherwise tell me and I'll make them. Thanks.

@skyclouds2001
Copy link
Contributor

ServiceWorkerRegistration.sync can also mark as non-experimental, too

@sidewayss
Copy link
Contributor Author

I have tagged ServiceWorkerRegistration.sync as not experimental.

@queengooborg queengooborg merged commit 9f46278 into mdn:main Mar 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants