Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

CI run against Twisted trunk is failing #14296

Closed
github-actions bot opened this issue Oct 26, 2022 · 4 comments · Fixed by #14305
Closed

CI run against Twisted trunk is failing #14296

github-actions bot opened this issue Oct 26, 2022 · 4 comments · Fixed by #14305
Labels
A-Packaging Our Debian packages, docker images; or issues relevant to downstream packagers T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. X-Regression Something broke which worked on a previous release

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2022

See https://github.com/matrix-org/synapse/actions/runs/3329668215

@DMRobertson
Copy link
Contributor

DMRobertson commented Oct 26, 2022

Covered by #14298

@DMRobertson
Copy link
Contributor

Actually no:

 + poetry add -n --extras tls git+https://github.com/twisted/twisted.git#trunk

Updating dependencies
Resolving dependencies...

  KeyError

  'None'

  at /opt/pipx/venvs/poetry/lib/python3.8/site-packages/poetry/mixology/version_solver.py:112 in _propagate
      108│             # Iterate in reverse because conflict resolution tends to produce more
      109│             # general incompatibilities as time goes on. If we look at those first,
      110│             # we can derive stronger assignments sooner and more eagerly find
      111│             # conflicts.
    → 112│             for incompatibility in reversed(self._incompatibilities[package]):
      113│                 result = self._propagate_incompatibility(incompatibility)
      114│ 
      115│                 if result is _conflict:
      116│                     # If the incompatibility is satisfied by the solution, we use

Presumably related to twisted/twisted#11655?

@DMRobertson DMRobertson added A-Packaging Our Debian packages, docker images; or issues relevant to downstream packagers T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. X-Regression Something broke which worked on a previous release T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. and removed T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. labels Oct 26, 2022
@ofek
Copy link

ofek commented Oct 26, 2022

Upgrade Poetry

@DMRobertson
Copy link
Contributor

Uh oh, you're quite right:

pipx install poetry==1.1.14

Missed in the 1.67.0 release. We use 1.2.0 everywhere else.

DMRobertson pushed a commit that referenced this issue Oct 26, 2022
Surprised it worked without this tbh!

Fixes #14296. Hopefully.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Packaging Our Debian packages, docker images; or issues relevant to downstream packagers T-Defect Bugs, crashes, hangs, security vulnerabilities, or other reported issues. X-Regression Something broke which worked on a previous release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants