Skip to content
This repository was archived by the owner on Sep 27, 2024. It is now read-only.

Revert "[iOS] Disabling auto correction" + disable only inline prediction #946

Merged
merged 10 commits into from
Mar 12, 2024

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Mar 12, 2024

Reverts #942

@Velin92 Velin92 added the iOS label Mar 12, 2024
@Velin92 Velin92 requested a review from pixlwave March 12, 2024 15:48
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Co-authored-by: Doug <6060466+pixlwave@users.noreply.github.com>
@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 88.39%. Comparing base (13573d4) to head (b040b87).

Files Patch % Lines
...ents/WysiwygComposerView/WysiwygComposerView.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #946      +/-   ##
============================================
+ Coverage     87.41%   88.39%   +0.98%     
============================================
  Files           167      118      -49     
  Lines         19223    17072    -2151     
  Branches       1049      634     -415     
============================================
- Hits          16803    15091    -1712     
+ Misses         2107     1952     -155     
+ Partials        313       29     -284     
Flag Coverage Δ
uitests ?
uitests-android ?
uitests-ios ?
unittests 88.39% <80.00%> (+2.75%) ⬆️
unittests-android ?
unittests-ios 76.09% <80.00%> (+0.93%) ⬆️
unittests-rust 89.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Velin92 added 6 commits March 12, 2024 17:23
…://github.com/matrix-org/matrix-wysiwyg into revert-942-mauroromito/disable_autocorrection

# Conflicts:
#	.github/workflows/ios.yml
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Velin92 Velin92 merged commit db9e591 into main Mar 12, 2024
7 checks passed
@Velin92 Velin92 deleted the revert-942-mauroromito/disable_autocorrection branch March 12, 2024 17:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants