Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable invariant assertions by default #685

Merged
merged 2 commits into from
May 23, 2023

Conversation

jonnyandrew
Copy link
Contributor

@jonnyandrew jonnyandrew commented May 22, 2023

Disable invariant assertions by default so that they are not run in release builds.

Note

  • The invariant assertions will still be run in tests.
  • After this change, the invariant assertions will no longer run in iOS and web example apps so follow-up work is needed to fix that.

@jonnyandrew jonnyandrew requested a review from a team May 22, 2023 15:58
@sonarcloud
Copy link

sonarcloud bot commented May 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +2.91 🎉

Comparison is base (41955f0) 86.86% compared to head (d4f54eb) 89.77%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #685      +/-   ##
============================================
+ Coverage     86.86%   89.77%   +2.91%     
============================================
  Files           143       78      -65     
  Lines         16196    13495    -2701     
  Branches        761        0     -761     
============================================
- Hits          14068    12115    -1953     
+ Misses         1940     1380     -560     
+ Partials        188        0     -188     
Flag Coverage Δ
uitests ?
uitests-android ?
unittests 89.77% <ø> (+2.11%) ⬆️
unittests-android ?
unittests-ios ?
unittests-rust 89.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 65 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@aringenbach aringenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonnyandrew jonnyandrew merged commit ad825a8 into main May 23, 2023
10 checks passed
@jonnyandrew jonnyandrew deleted the jonny/fix/no-assert-invariants-by-default branch May 23, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants