Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2.2.0 #683

Merged
merged 3 commits into from
May 18, 2023
Merged

Version 2.2.0 #683

merged 3 commits into from
May 18, 2023

Conversation

jonnyandrew
Copy link
Contributor

No description provided.

@jonnyandrew jonnyandrew requested a review from a team May 18, 2023 08:31
@codecov-commenter
Copy link

codecov-commenter commented May 18, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.02 🎉

Comparison is base (a3e4e38) 86.86% compared to head (1d6faed) 86.88%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #683      +/-   ##
============================================
+ Coverage     86.86%   86.88%   +0.02%     
  Complexity      272      272              
============================================
  Files           143      143              
  Lines         16196    16196              
  Branches        761      762       +1     
============================================
+ Hits          14068    14072       +4     
+ Misses         1940     1936       -4     
  Partials        188      188              
Flag Coverage Δ
uitests 65.24% <ø> (ø)
uitests-android 65.24% <ø> (ø)
unittests 87.68% <ø> (+0.02%) ⬆️
unittests-android 58.28% <ø> (ø)
unittests-ios 77.75% <ø> (+0.28%) ⬆️
unittests-rust 89.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@langleyd
Copy link
Contributor

Should we run all tests on releases do you think @jonnyandrew ? Either by adding all the platform tag or adding a release tag and checking it?

@jonnyandrew
Copy link
Contributor Author

jonnyandrew commented May 18, 2023

Should we run all tests on releases do you think @jonnyandrew ? Either by adding all the platform tag or adding a release tag and checking it?

Yeah I think that's a good idea - hopefully that will stop us accidentally trying to base a release on a broken main branch. Would it make sense to make it automatic rather than remembering to add labels (like f9eff01)?

@sonarcloud
Copy link

sonarcloud bot commented May 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jonnyandrew jonnyandrew merged commit 1ac992c into main May 18, 2023
10 checks passed
@jonnyandrew jonnyandrew deleted the version-2.2.0 branch May 18, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants