Read attributes from markdown for mentions #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 11, 2023 12:29
aringenbach
reviewed
May 12, 2023
I'm trying to do this but don't really understand the code structure here. Where would this be tested? It's the greyed out code for this module that's confusing me |
added 3 commits
May 12, 2023 16:18
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #675 +/- ##
============================================
+ Coverage 86.83% 89.77% +2.94%
============================================
Files 140 78 -62
Lines 16120 13495 -2625
Branches 750 0 -750
============================================
- Hits 13997 12115 -1882
+ Misses 1941 1380 -561
+ Partials 182 0 -182
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
Kudos, SonarCloud Quality Gate passed!
|
jonnyandrew
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there was the refactor to add the ability to pass attributes in when creating links, this function was missed.
Amending this function to pass through (specified) attributes means that now we will be able to pass a mention from the plain text editor (ie "markdown") into the rich text editor and have the rust model be instantiated containing that mention with the required attributes.