FIX: wspace and hspace in subfigures without layout engine #25960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcomer
added
topic: geometry manager
rcomer
added
topic: figures and subfigures
and removed
topic: geometry manager
1 task
oscargus
approved these changes
Jun 19, 2023
QuLogic
reviewed
Jun 22, 2023
rcomer
force-pushed
the
subfigure-spacing
branch
from
e2fa1ae
to
5d9c630
Compare
QuLogic
approved these changes
Jul 5, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jul 5, 2023
…thout layout engine
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jul 6, 2023
…t-of-pr-25960-on-v3.7.x Backport PR matplotlib#25960 on branch v3.7.x (FIX: wspace and hspace in subfigures without layout engine)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Fixes #25511. As discussed in that issue, sometimes a subfigure may be added on a gridspec that is also used for subplots, and it makes sense that the subplots would have larger wspace and hspace than the subfigures would. So for
Figure.add_subfigureand theSubFigureinstantiation method, it makes sense to continue ignoring any white space settings on the passed gridspec. This PR therefore only modifies thesubfiguresmethod, updating the subfigure positions after instantiation.PR checklist