Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix displacement of colorbar for eps with bbox_inches='tight' #25193

Merged
merged 1 commit into from Feb 11, 2023
Merged

Fix displacement of colorbar for eps with bbox_inches='tight' #25193

merged 1 commit into from Feb 11, 2023

Conversation

ksunden
Copy link
Member

@ksunden ksunden commented Feb 10, 2023

Co-authored-by: Antony Lee anntzer.lee@gmail.com

Closes #25176

PR Summary

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

@ksunden ksunden added this to the v3.7.0 milestone Feb 10, 2023
@tacaswell
Copy link
Member

I'm going to say that between this being @anntzer 's patch, @ksunden writing it up and adding a test and my review we have crossed the "2 reviewers" threshold and will merge this when green.

anntzer
anntzer approved these changes Feb 10, 2023
View reviewed changes
Copy link
Contributor

@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post ci.

@ksunden
Fix displacement of colorbar for eps with bbox_inches='tight'
284827c 
Co-authored-by: Antony Lee <anntzer.lee@gmail.com>

Closes matplotlib#25176
@anntzer anntzer merged commit 9ff38a8 into matplotlib:main Feb 11, 2023
@meeseeksmachine meeseeksmachine mentioned this pull request Feb 11, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Feb 11, 2023
@anntzer @meeseeksmachine
Backport PR matplotlib#25193: Fix displacement of colorbar for eps wi…
3e0e0b3 
…th bbox_inches='tight'
oscargus added a commit that referenced this pull request Feb 11, 2023
@oscargus
Merge pull request #25197 from meeseeksmachine/auto-backport-of-pr-25…
172ede3 
…193-on-v3.7.x

Backport PR #25193 on branch v3.7.x (Fix displacement of colorbar for eps with bbox_inches='tight')
@ksunden ksunden mentioned this pull request Feb 20, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscargus oscargus oscargus left review comments

@tacaswell tacaswell tacaswell approved these changes

@anntzer anntzer anntzer approved these changes

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
backend: ps
Projects
None yet
Milestone
v3.7.0
Development

Successfully merging this pull request may close these issues.

[Bug]: Colorbar is displaced when saving as .eps with bbox_inches='tight'
6 participants
@ksunden @tacaswell @anntzer @jklymak @oscargus @QuLogic