Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditionally apply Logger.warning/2 or Logger.warn/1 #20

Merged
merged 2 commits into from May 30, 2023
Merged

Conditionally apply Logger.warning/2 or Logger.warn/1 #20

merged 2 commits into from May 30, 2023

Conversation

kipcole9
Copy link
Contributor

Relates to Issue #19.

@kipcole9
Conditionally use Logger.warning or Logger.warn
d8e8d56 
Elixir 1.15 deprecates Logger.warn/1 so this commit
conditionally applies either Logger.warning/2 or
Logger.warn/1 on older releases.
@kipcole9
Conditionally add Calendar callbacks to Holocene
f95a7e7 
Avoids test compile warnings by conditionally adding
callbacks to the Support.Holocene calendar in the
test suite.
@kipcole9
Copy link
Contributor Author

@mathieuprog anything more you'd like me to add/modify to this?

@mathieuprog mathieuprog merged commit b774002 into mathieuprog:master May 30, 2023
@mathieuprog mathieuprog added the enhancement New feature or request label May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kipcole9 @mathieuprog