Fix GridFSURIStore and increase testing #1037
Merged
+57
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing GridFSURIStore I discovered that there are several potential sources of errors due to the fact that it uses methods of the baseclass (GridFSStore), even if some attributes are not defined. Also there are no safeguard for accessing the
_files_store
attribute in case the store is not connected.This PR addresses these issues and modifies the gridfs tests so that all the tests are executed on both the
GridFSStore
andGridFSURIStore
. This should hopefully reduce the chances of regression.Also I noted that the
ssh_tunnel
is not taken into account in either of the "URI" stores. I kept the argument in the__init__
to maintain the same API as the base classes, but it explicitly raises if passed.