Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use create_user_settings for new users posting settings for the first… #837

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

yang-ruoxi
Copy link
Member

Added a method for creating user settings that uses post_resource.
This will work with the web to avoid the situation where new user can't set their settings

@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5f15be1) 69.64% compared to head (50844cc) 69.64%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #837   +/-   ##
=======================================
  Coverage   69.64%   69.64%           
=======================================
  Files          51       51           
  Lines        2418     2418           
=======================================
  Hits         1684     1684           
  Misses        734      734           
Files Changed Coverage Δ
mp_api/client/routes/_user_settings.py 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@munrojm munrojm added the release:patch Patch release label Aug 16, 2023
@munrojm munrojm merged commit 7cbf363 into main Aug 16, 2023
11 checks passed
@munrojm munrojm deleted the bugfix/user_settings branch August 30, 2023 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:patch Patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants