Fix MPRester doc string for notify_db_version #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mentioned old location ~/.pmgrc.yaml for logging MP DB version, should now be ~/.mprester.log.yaml?
|
@janosh, I will take care of implementing this so it is consistent. |
|
@munrojm This is ready to merge. Given the change affects only a doc string, the test failures are unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@munrojm The old MPRester was changed to log the queried MP DB version to
~/.mprester.log.yamlinstead of~/.pmgrc.yaml. How about the new Rester? The doc string still mentioned the old location where it's definitely not logged to. But new Rester doesn't log at all?Related: Was looking at the code due to this question https://matsci.org/t/46913.