Deprecate __version__ and related attributes #2229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lafrech
approved these changes
Feb 12, 2024
| __version_info__ += __parsed_version__.pre # type: ignore[assignment] | ||
|
|
||
| def __getattr__(name: str) -> typing.Any: | ||
| import warnings |
There was a problem hiding this comment.
I suppose this is imported here to avoid a useless import in normal use.
I don't mind either way.
There was a problem hiding this comment.
This turns out to be necessary to avoid an error. If the import is moved to the top, you get
AttributeError: module 'marshmallow.warnings' has no attribute 'warn'flask does the same https://github.com/pallets/flask/blob/b90a4f1f4a370e92054b9cc9db0efcb864f87ebe/src/flask/__init__.py#L49
There was a problem hiding this comment.
Oh, OK. Strange at first sight, but alright.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #2227
Follow-ups:
__version__et al. in other marshmallow-code repos