Switch to non-overflowing decoded length formula #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marshallpierce
force-pushed
the
mp/decode-estimate
branch
3 times, most recently
from
17a0fc8
to
4656094
Compare
No change to benchmarks. Motivated by the alternate approach in https://github.com/marshallpierce/rust-base64/pull/216/files.
marshallpierce
force-pushed
the
mp/decode-estimate
branch
from
4656094
to
fa47981
Compare
mina86
reviewed
Jan 20, 2023
tests/encode.rs
Outdated
Comment on lines
27
to
32
| let mut bytes = Vec::<u8>::with_capacity(256); | ||
|
|
||
| for i in 0..255 { | ||
| for i in 0..=255 { | ||
| bytes.push(i); | ||
| } | ||
| bytes.push(255); //bug with "overflowing" ranges? |
There was a problem hiding this comment.
let bytes: Vec<u8> = (0..=255).collect();
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No change to benchmarks.
Motivated by the alternate approach in #216.