Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct import of date-fns@v3 format #271

Merged
merged 4 commits into from
Mar 22, 2024
Merged

Correct import of date-fns@v3 format #271

merged 4 commits into from
Mar 22, 2024

Conversation

gugu
Copy link
Contributor

@gugu gugu commented Mar 22, 2024

No description provided.

@marnusw
Copy link
Owner

marnusw commented Mar 22, 2024

@gugu why did you add the prepare script which is the same as the build script?

@gugu
Copy link
Contributor Author

gugu commented Mar 22, 2024

@marnusw usually it allows to install the module from github directly (without waiting for npm). But this time it did not work.

when I run npm install github:user/date-fns-tz#branch it checks out the repo and runs npm prepare to build a package

@gugu
Copy link
Contributor Author

gugu commented Mar 22, 2024

@marnusw fixed build as well

@marnusw marnusw merged commit ee1acd7 into marnusw:master Mar 22, 2024
3 checks passed
@marnusw
Copy link
Owner

marnusw commented Mar 22, 2024

Amazing @gugu, thank you. I have fixed a few more imports and published 3.0.0-beta.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants