Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: deprecated trimLeft/trimRight #2973

Merged
merged 1 commit into from Sep 6, 2023
Merged

fix: deprecated trimLeft/trimRight #2973

merged 1 commit into from Sep 6, 2023

Conversation

immccn123
Copy link
Contributor

Marked version: v8.0.0

Description

String.prototype.trimLeft() / trimRight() is deprecated for ES2019. Changed to use trimStart() / trimEnd() instead.

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

@vercel
Copy link

vercel bot commented Sep 6, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marked-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2023 8:50am

@immccn123
Copy link
Contributor Author

immccn123 commented Sep 6, 2023 •
edited

Not compatible with Safari.

Sorry I made a mistake.

@immccn123 immccn123 closed this Sep 6, 2023
@immccn123 immccn123 reopened this Sep 6, 2023
@UziTech UziTech merged commit eda75a6 into markedjs:master Sep 6, 2023
11 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 6, 2023
@semantic-release-bot
chore(release): 8.0.1 [skip ci]
ccc7a8f 
## [8.0.1](v8.0.0...v8.0.1) (2023-09-06)

### Bug Fixes

* deprecated trimLeft/trimRight ([#2973](#2973)) ([eda75a6](eda75a6))
* fix space removed after checkbox ([#2971](#2971)) ([9a2a4ad](9a2a4ad))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UziTech UziTech UziTech approved these changes

@calculuschild calculuschild calculuschild approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@immccn123 @UziTech @calculuschild