BREAKING CHANGE: Clean up files in repo #2963
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
UziTech
force-pushed
the
remove-built
branch
from
8782b08
to
5d36c43
Compare
UziTech
changed the title
We actually don't need |
| @@ -24,6 +25,8 @@ async function init() { | |||
| console.log('Cleaning up output directory ' + outputDir); | |||
| await rm(outputDir, { force: true, recursive: true }); | |||
| await mkdir(outputDir); | |||
| console.log(`Copying file ${join(cwd, 'LICENSE.md')}`); | |||
| console.log(` to ${join(inputDir, 'LICENSE.md')}`); | |||
| await copyFile(join(cwd, 'LICENSE.md'), join(inputDir, 'LICENSE.md')); | |||
There was a problem hiding this comment.
Let's add something like:
await copyFile(join(cwd, 'marked.min.js'), join(outputDir, 'marked.min.js''));Then in the client side JS of the Demo, you can fetch the latest for the given deployment with:
fetch(new URL('/marked.min.js', window.location))`There was a problem hiding this comment.
Is there a way to get the PR vercel link with just a PR#?
There was a problem hiding this comment.
I found it based on the vercel comment View Preview link
There was a problem hiding this comment.
or we don't even need the pr version because now we can go to the preview and use /marked.min.js
There was a problem hiding this comment.
Exactly, we don’t need a text input anymore. Either you select an old version or you select “HEAD”. And HEAD for a production deployment is master branch and for a preview deployment it’s the PR branch.
# [9.0.0](v8.0.1...v9.0.0) (2023-09-09) ### Bug Fixes * Clean up files in repo ([#2963](#2963)) ([7d95a91](7d95a91)) ### BREAKING CHANGES * - remove built files from git repo. - If you need to use the latest version of marked on the web you can use a cdn to get marked.min.js from npm: - `https://cdn.jsdelivr.net/npm/marked/marked.min.js`
Marked version: 8.0.0
Description
Clean up files that are not needed in repo. I left
marked.min.jssince we need it in the repo to run our demo on master and specific commits and prs.This is only breaking if someone uses the files in lib/ on the master branch. Technically they were never meant to be used so I'm not sure we actually need to bump the major version.
Contributor
Committer
In most cases, this should be a different person than the contributor.