docs: update docs #2928
docs: update docs #2928
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Looks fine to me. Only comment is the response time seems to be way off. I.e., if I paste in a huge block, the output panel will time out saying (took longer than 1 second... 2 seconds.... 3 seconds) and eventually render, then the Response Time happily animates to say "177ms!". |
|
The response time is the time it took marked to parse the markdown. The time it takes to send the payload to and from the worker is not included. |
| @@ -38,14 +45,7 @@ async function build(currentDir, tmpl) { | |||
| let buffer = await readFile(filename); | |||
There was a problem hiding this comment.
I think we should add utf8 here to work with the string instead of the buffer..
That can be a future PR 😄
| @@ -10,14 +10,14 @@ | |||
| - [ ] Run `npm run build:reset` to remove changes to compiled files. | |||
| - [ ] Submit a Pull Request. | |||
|
|
|||
| ## Design principles | |||
| <h2 id="design-principles">Design principles</h2> | |||
There was a problem hiding this comment.
Should we enable header ids instead of doing this manually?
There was a problem hiding this comment.
We are already doing it manually in most of our pages so the ids don't get too long. I think we should keep it consistent and we don't want to change it for existing ids otherwise urls will break.
Co-authored-by: Steven <steven@ceriously.com>
Description
Update docs
Contributor
Committer
In most cases, this should be a different person than the contributor.